Re: [PATCH net-next v3 2/2] net: phy: at803x: disable delay only for RGMII mode

2019-02-19 Thread Marc Gonzalez
On 19/02/2019 13:33, Niklas Cassel wrote: > However, since the bootloader might have enabled delay on > TX, I still think that this patch does the right thing by > starting out with disabling delays for both RX and TX. > > But we should probably make the comment more elaborate: > > The value aft

Re: [PATCH net-next v3 2/2] net: phy: at803x: disable delay only for RGMII mode

2019-02-19 Thread Niklas Cassel
On Tue, Feb 19, 2019 at 12:57:18PM +0100, Marc Gonzalez wrote: > On 19/02/2019 07:18, Vinod Koul wrote: > > > Per "Documentation/devicetree/bindings/net/ethernet.txt" RGMII mode > > should not have delay in PHY whereas RGMII_ID and RGMII_RXID/RGMII_TXID > > can have delay in phy. > > PHY or phy?

Re: [PATCH net-next v3 2/2] net: phy: at803x: disable delay only for RGMII mode

2019-02-19 Thread Marc Gonzalez
On 19/02/2019 07:18, Vinod Koul wrote: > Per "Documentation/devicetree/bindings/net/ethernet.txt" RGMII mode > should not have delay in PHY whereas RGMII_ID and RGMII_RXID/RGMII_TXID > can have delay in phy. PHY or phy? :-) > So disable the delay only for RGMII mode and enable for other modes. >

[PATCH net-next v3 2/2] net: phy: at803x: disable delay only for RGMII mode

2019-02-18 Thread Vinod Koul
Per "Documentation/devicetree/bindings/net/ethernet.txt" RGMII mode should not have delay in PHY whereas RGMII_ID and RGMII_RXID/RGMII_TXID can have delay in phy. So disable the delay only for RGMII mode and enable for other modes. Also treat the default case as disabled delays. Fixes: cd28d1d6e5