Re: [PATCH net-next v3 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs

2015-11-24 Thread Jakub Kicinski
On Tue, 24 Nov 2015 14:25:31 -0500 (EST), David Miller wrote: > From: Jakub Kicinski > Date: Mon, 23 Nov 2015 11:04:57 + > > > +#ifdef CONFIG_NFP_NET_DEBUG > > +#define DEBUG > > +#endif > > Do not design ad-hoc debug logging facilities locally in your driver, > and instead use the existing

Re: [PATCH net-next v3 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs

2015-11-24 Thread David Miller
From: Jakub Kicinski Date: Mon, 23 Nov 2015 11:04:57 + > +#ifdef CONFIG_NFP_NET_DEBUG > +#define DEBUG > +#endif Do not design ad-hoc debug logging facilities locally in your driver, and instead use the existing tree wide facilities as they were designed to be used so that any user can get d