Re: [PATCH net-next v3 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-10 Thread Michael Chan
On Sun, Dec 10, 2017 at 9:02 AM, Alexander Duyck wrote: > On Sat, Dec 9, 2017 at 10:40 PM, Michael Chan > wrote: >> It is possible that if you have incoming packets 1, 2, 3, 4, 5 for a >> TCP connection, HW_GRO can aggregate packets 1, 2, 3, but cannot >> aggregate packets 4 and 5 due to hardwar

Re: [PATCH net-next v3 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-10 Thread Alexander Duyck
On Sat, Dec 9, 2017 at 10:40 PM, Michael Chan wrote: > On Sat, Dec 9, 2017 at 2:04 PM, Alexander Duyck > wrote: >> On Sat, Dec 9, 2017 at 1:31 PM, Michael Chan >> wrote: >>> On Sat, Dec 9, 2017 at 10:50 AM, Alexander Duyck >>> wrote: So I would disagree with it being a subset of NETIF_F_G

Re: [PATCH net-next v3 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-09 Thread Michael Chan
On Sat, Dec 9, 2017 at 2:04 PM, Alexander Duyck wrote: > On Sat, Dec 9, 2017 at 1:31 PM, Michael Chan > wrote: >> On Sat, Dec 9, 2017 at 10:50 AM, Alexander Duyck >> wrote: >>> So I would disagree with it being a subset of NETIF_F_GRO. If anything >>> it is an alternative to NETIF_F_GRO. It is

Re: [PATCH net-next v3 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-09 Thread Alexander Duyck
On Sat, Dec 9, 2017 at 1:31 PM, Michael Chan wrote: > On Sat, Dec 9, 2017 at 10:50 AM, Alexander Duyck > wrote: >> On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan >> wrote: >>> Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware >>> GRO. With this flag, we can now independently

Re: [PATCH net-next v3 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-09 Thread Michael Chan
On Sat, Dec 9, 2017 at 10:50 AM, Alexander Duyck wrote: > On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan > wrote: >> Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware >> GRO. With this flag, we can now independently turn on or off hardware >> GRO when GRO is on. Previously, d

Re: [PATCH net-next v3 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-09 Thread Alexander Duyck
On Fri, Dec 8, 2017 at 10:27 PM, Michael Chan wrote: > Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware > GRO. With this flag, we can now independently turn on or off hardware > GRO when GRO is on. Previously, drivers were using NETIF_F_GRO to > control hardware GRO and so it

[PATCH net-next v3 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-08 Thread Michael Chan
Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware GRO. With this flag, we can now independently turn on or off hardware GRO when GRO is on. Previously, drivers were using NETIF_F_GRO to control hardware GRO and so it cannot be independently turned on or off without affecting GR