Re: [PATCH net-next v3 1/4] bpf, mlx5: fix mlx5e_create_rq taking reference on prog

2016-11-21 Thread Saeed Mahameed
On Sat, Nov 19, 2016 at 2:45 AM, Daniel Borkmann wrote: > In mlx5e_create_rq(), when creating a new queue, we call bpf_prog_add() but > without checking the return value. bpf_prog_add() can fail since 92117d8443bc > ("bpf: fix refcnt overflow"), so we really must check it. Take the reference > rig

[PATCH net-next v3 1/4] bpf, mlx5: fix mlx5e_create_rq taking reference on prog

2016-11-18 Thread Daniel Borkmann
In mlx5e_create_rq(), when creating a new queue, we call bpf_prog_add() but without checking the return value. bpf_prog_add() can fail since 92117d8443bc ("bpf: fix refcnt overflow"), so we really must check it. Take the reference right when we assign it to the rq from priv->xdp_prog, and just drop