Re: [PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

2018-05-17 Thread Roopa Prabhu
On Wed, May 16, 2018 at 7:36 PM, David Miller wrote: > From: Roopa Prabhu > Date: Wed, 16 May 2018 13:30:28 -0700 > >> yes, but we hold rcu read lock before calling the reply function for >> fib result. I did consider allocating the skb before the read >> lock..but then the refactoring (into a s

Re: [PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

2018-05-16 Thread David Miller
From: Roopa Prabhu Date: Wed, 16 May 2018 13:30:28 -0700 > yes, but we hold rcu read lock before calling the reply function for > fib result. I did consider allocating the skb before the read > lock..but then the refactoring (into a separate netlink reply func) > would seem unnecessary. > > I a

Re: [PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

2018-05-16 Thread Roopa Prabhu
On Wed, May 16, 2018 at 11:37 AM, David Miller wrote: > From: Roopa Prabhu > Date: Tue, 15 May 2018 20:55:06 -0700 > >> +static int inet_rtm_getroute_reply(struct sk_buff *in_skb, struct nlmsghdr >> *nlh, >> +__be32 dst, __be32 src, struct flowi4 *fl4, >> +

Re: [PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

2018-05-16 Thread David Miller
From: Roopa Prabhu Date: Tue, 15 May 2018 20:55:06 -0700 > +static int inet_rtm_getroute_reply(struct sk_buff *in_skb, struct nlmsghdr > *nlh, > +__be32 dst, __be32 src, struct flowi4 *fl4, > +struct rtable *rt, struct fib_result *r

[PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

2018-05-15 Thread Roopa Prabhu
From: Roopa Prabhu This is a followup to fib rules sport, dport and ipproto match support. Only supports tcp, udp and icmp for ipproto. Used by fib rule self tests. Before this patch getroute used same skb to pass through the route lookup and for the netlink getroute reply msg. This patch allocat