Re: [PATCH net-next v3 1/2] net: dsa: qca8k: Add define for port VID

2020-08-03 Thread David Miller
From: Jonathan McDowell Date: Sat, 1 Aug 2020 18:05:54 +0100 > Rather than using a magic value of 1 when configuring the port VIDs add > a QCA8K_PORT_VID_DEF define and use that instead. Also fix up the > bitmask in the process; the top 4 bits are reserved so this wasn't a > problem, but only mas

Re: [PATCH net-next v3 1/2] net: dsa: qca8k: Add define for port VID

2020-08-02 Thread Vladimir Oltean
On Sat, Aug 01, 2020 at 06:05:54PM +0100, Jonathan McDowell wrote: > Rather than using a magic value of 1 when configuring the port VIDs add > a QCA8K_PORT_VID_DEF define and use that instead. Also fix up the > bitmask in the process; the top 4 bits are reserved so this wasn't a > problem, but only

Re: [PATCH net-next v3 1/2] net: dsa: qca8k: Add define for port VID

2020-08-01 Thread Florian Fainelli
On 8/1/2020 10:05 AM, Jonathan McDowell wrote: > Rather than using a magic value of 1 when configuring the port VIDs add > a QCA8K_PORT_VID_DEF define and use that instead. Also fix up the > bitmask in the process; the top 4 bits are reserved so this wasn't a > problem, but only masking 12 bits

[PATCH net-next v3 1/2] net: dsa: qca8k: Add define for port VID

2020-08-01 Thread Jonathan McDowell
Rather than using a magic value of 1 when configuring the port VIDs add a QCA8K_PORT_VID_DEF define and use that instead. Also fix up the bitmask in the process; the top 4 bits are reserved so this wasn't a problem, but only masking 12 bits is the correct approach. Signed-off-by: Jonathan McDowell