Re: [PATCH net-next v3 1/1] net sched actions: Add support for user cookies

2017-01-17 Thread David Miller
From: Jamal Hadi Salim Date: Tue, 17 Jan 2017 05:52:15 -0500 > Having said that: Is this rule really cast in stone?;-> > I have seen many other people (including myself) sneak in whitespace > changes and other trivialities in a general change. I thought the rule > was to not do such things for bu

Re: [PATCH net-next v3 1/1] net sched actions: Add support for user cookies

2017-01-17 Thread Jamal Hadi Salim
On 17-01-16 02:46 PM, David Miller wrote: Jamal, please don't mix coding style and real changes. Have one patch that adds the user cookies and one that cleans up the coding style stuff. Thanks. I will separate those changes (gives me an opportunity to make more stylistic changes). Having s

Re: [PATCH net-next v3 1/1] net sched actions: Add support for user cookies

2017-01-16 Thread David Miller
Jamal, please don't mix coding style and real changes. Have one patch that adds the user cookies and one that cleans up the coding style stuff. Thanks.

Re: [PATCH net-next v3 1/1] net sched actions: Add support for user cookies

2017-01-15 Thread Jiri Pirko
Sun, Jan 15, 2017 at 04:18:20PM CET, j...@mojatatu.com wrote: >On 17-01-15 10:01 AM, Jiri Pirko wrote: >> Sun, Jan 15, 2017 at 03:01:19PM CET, j...@mojatatu.com wrote: > >> > +cls_set_class(struct tcf_proto *tp, unsigned long *clp, >> >> ?? >> >> >unsigned long cl) >> > { >> >unsigned lon

Re: [PATCH net-next v3 1/1] net sched actions: Add support for user cookies

2017-01-15 Thread Jamal Hadi Salim
On 17-01-15 10:01 AM, Jiri Pirko wrote: Sun, Jan 15, 2017 at 03:01:19PM CET, j...@mojatatu.com wrote: +cls_set_class(struct tcf_proto *tp, unsigned long *clp, ?? unsigned long cl) { unsigned long old_cl; - + ?? tcf_tree_lock(tp); old_cl = __cls_se

Re: [PATCH net-next v3 1/1] net sched actions: Add support for user cookies

2017-01-15 Thread Jiri Pirko
Sun, Jan 15, 2017 at 03:01:19PM CET, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >Introduce optional 128-bit action cookie. >Like all other cookie schemes in the networking world (eg in protocols >like http or existing kernel fib protocol field, etc) the idea is to save >user state that whe

[PATCH net-next v3 1/1] net sched actions: Add support for user cookies

2017-01-15 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved serves as a correlator. The kernel _should not_ intepret