Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-16 Thread David Miller
From: Tom Herbert Date: Tue, 14 Mar 2017 19:30:47 -0700 > Agreed, but then why do we even need any complexity here by that > argument? RSS is specifically defined to do 5-tuple hashing for TCP > (and UDP), and 3-tuple. No one has ever complained that doing per flow > RSS for TCP is bad thing AFAI

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-15 Thread Stephen Hemminger
On Wed, 15 Mar 2017 09:01:16 -0600 David Ahern wrote: > On 3/15/17 3:17 AM, Nicolas Dichtel wrote: > >>> Is there another patch to add the NETCONFA_ECMP support? > >>> > >> > >> does userspace care? > > Yes, I think it is needed so that userspace can correctly monitor this > > behavior. > >

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-15 Thread David Ahern
On 3/15/17 3:17 AM, Nicolas Dichtel wrote: >>> Is there another patch to add the NETCONFA_ECMP support? >>> >> >> does userspace care? > Yes, I think it is needed so that userspace can correctly monitor this > behavior. > It also enables to check this parameter through netlink. > I don't underst

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-15 Thread Nikolay Aleksandrov
On 15/03/17 13:32, Jakub Sitnicki wrote: > On Tue, Mar 14, 2017 at 03:36 PM GMT, Nikolay Aleksandrov wrote: >> This patch adds support for ECMP hash policy choice via a new sysctl >> called fib_multipath_hash_policy and also adds support for L4 hashes. >> The current values for fib_multipath_hash_p

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-15 Thread Jakub Sitnicki
On Tue, Mar 14, 2017 at 03:36 PM GMT, Nikolay Aleksandrov wrote: > This patch adds support for ECMP hash policy choice via a new sysctl > called fib_multipath_hash_policy and also adds support for L4 hashes. > The current values for fib_multipath_hash_policy are: > 0 - layer 3 (default) > 1 - lay

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-15 Thread Nikolay Aleksandrov
> On Mar 15, 2017, at 1:18 PM, Nicolas Dichtel > wrote: > > Le 15/03/2017 à 11:46, Nikolay Aleksandrov a écrit : > [snip] >> This doesn’t fit the NETCONFA model well, there is no “all”, “default” or >> per iface option to be set, also >> the other multipath sysctl which affects behaviour doesn

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-15 Thread Nicolas Dichtel
Le 15/03/2017 à 11:46, Nikolay Aleksandrov a écrit : [snip] > This doesn’t fit the NETCONFA model well, there is no “all”, “default” or per > iface option to be set, also > the other multipath sysctl which affects behaviour doesn’t have a > notification. Right. Maybe adding a "system-wide" option

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-15 Thread Nikolay Aleksandrov
> On Mar 15, 2017, at 11:17 AM, Nicolas Dichtel > wrote: > > Le 15/03/2017 à 00:45, David Ahern a écrit : >> On 3/14/17 5:27 PM, Stephen Hemminger wrote: >>> On Tue, 14 Mar 2017 15:38:40 -0700 >>> Roopa Prabhu wrote: >>> > That's what my initial version did, but this was discussed dur

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-15 Thread Nicolas Dichtel
Le 15/03/2017 à 00:45, David Ahern a écrit : > On 3/14/17 5:27 PM, Stephen Hemminger wrote: >> On Tue, 14 Mar 2017 15:38:40 -0700 >> Roopa Prabhu wrote: >> That's what my initial version did, but this was discussed during NetConf in Seville and it was decided that it's

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread Tom Herbert
On Tue, Mar 14, 2017 at 5:24 PM, David Miller wrote: > From: Stephen Hemminger > Date: Tue, 14 Mar 2017 13:25:06 -0700 > >> On Tue, 14 Mar 2017 11:48:37 -0700 (PDT) >> David Miller wrote: >> >>> From: Nikolay Aleksandrov >>> Date: Tue, 14 Mar 2017 17:58:46 +0200 >>> >>> > On 14/03/17 17:55, Ste

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread David Miller
From: Stephen Hemminger Date: Tue, 14 Mar 2017 13:25:06 -0700 > On Tue, 14 Mar 2017 11:48:37 -0700 (PDT) > David Miller wrote: > >> From: Nikolay Aleksandrov >> Date: Tue, 14 Mar 2017 17:58:46 +0200 >> >> > On 14/03/17 17:55, Stephen Hemminger wrote: >> >> On Tue, 14 Mar 2017 17:36:15 +0200

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread David Ahern
On 3/14/17 5:27 PM, Stephen Hemminger wrote: > On Tue, 14 Mar 2017 15:38:40 -0700 > Roopa Prabhu wrote: > >>> That's what my initial version did, but this was discussed during >>> NetConf in Seville >>> and it was decided that it's best to make a global sysctl, thus the >>> chan

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread Stephen Hemminger
On Tue, 14 Mar 2017 15:38:40 -0700 Roopa Prabhu wrote: > >> >> > That's what my initial version did, but this was discussed during > >> >> > NetConf in Seville > >> >> > and it was decided that it's best to make a global sysctl, thus the > >> >> > change. > >> >> > >> >> Correct, we discussed

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread Roopa Prabhu
On Tue, Mar 14, 2017 at 2:42 PM, Stephen Hemminger wrote: > On Tue, 14 Mar 2017 14:10:22 -0700 > Roopa Prabhu wrote: > >> On Tue, Mar 14, 2017 at 1:25 PM, Stephen Hemminger >> wrote: >> > On Tue, 14 Mar 2017 11:48:37 -0700 (PDT) >> > David Miller wrote: >> > >> >> From: Nikolay Aleksandrov [s

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread Stephen Hemminger
On Tue, 14 Mar 2017 14:10:22 -0700 Roopa Prabhu wrote: > On Tue, Mar 14, 2017 at 1:25 PM, Stephen Hemminger > wrote: > > On Tue, 14 Mar 2017 11:48:37 -0700 (PDT) > > David Miller wrote: > > > >> From: Nikolay Aleksandrov > >> Date: Tue, 14 Mar 2017 17:58:46 +0200 > >> > >> > On 14/03/17 17

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread Roopa Prabhu
On Tue, Mar 14, 2017 at 1:25 PM, Stephen Hemminger wrote: > On Tue, 14 Mar 2017 11:48:37 -0700 (PDT) > David Miller wrote: > >> From: Nikolay Aleksandrov >> Date: Tue, 14 Mar 2017 17:58:46 +0200 >> >> > On 14/03/17 17:55, Stephen Hemminger wrote: >> >> On Tue, 14 Mar 2017 17:36:15 +0200 >> >> Ni

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread Stephen Hemminger
On Tue, 14 Mar 2017 11:48:37 -0700 (PDT) David Miller wrote: > From: Nikolay Aleksandrov > Date: Tue, 14 Mar 2017 17:58:46 +0200 > > > On 14/03/17 17:55, Stephen Hemminger wrote: > >> On Tue, 14 Mar 2017 17:36:15 +0200 > >> Nikolay Aleksandrov wrote: > >> > >>> This patch adds support for

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread Nikolay Aleksandrov
> On Mar 14, 2017, at 5:36 PM, Nikolay Aleksandrov > wrote: > > This patch adds support for ECMP hash policy choice via a new sysctl > called fib_multipath_hash_policy and also adds support for L4 hashes. > The current values for fib_multipath_hash_policy are: > 0 - layer 3 (default) > 1 - laye

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 14 Mar 2017 17:58:46 +0200 > On 14/03/17 17:55, Stephen Hemminger wrote: >> On Tue, 14 Mar 2017 17:36:15 +0200 >> Nikolay Aleksandrov wrote: >> >>> This patch adds support for ECMP hash policy choice via a new sysctl >>> called fib_multipath_hash_policy and

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread Nikolay Aleksandrov
On 14/03/17 17:55, Stephen Hemminger wrote: > On Tue, 14 Mar 2017 17:36:15 +0200 > Nikolay Aleksandrov wrote: > >> This patch adds support for ECMP hash policy choice via a new sysctl >> called fib_multipath_hash_policy and also adds support for L4 hashes. >> The current values for fib_multipath_

Re: [PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread Stephen Hemminger
On Tue, 14 Mar 2017 17:36:15 +0200 Nikolay Aleksandrov wrote: > This patch adds support for ECMP hash policy choice via a new sysctl > called fib_multipath_hash_policy and also adds support for L4 hashes. > The current values for fib_multipath_hash_policy are: > 0 - layer 3 (default) > 1 - laye

[PATCH net-next v3] net: ipv4: add support for ECMP hash policy choice

2017-03-14 Thread Nikolay Aleksandrov
This patch adds support for ECMP hash policy choice via a new sysctl called fib_multipath_hash_policy and also adds support for L4 hashes. The current values for fib_multipath_hash_policy are: 0 - layer 3 (default) 1 - layer 4 If there's an skb hash already set and it matches the chosen policy th