Re: [PATCH net-next v3] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

2016-12-02 Thread Erik Nordmark
On 12/2/16 9:27 AM, David Miller wrote: From: Erik Nordmark Date: Wed, 30 Nov 2016 15:39:19 -0800 @@ -794,6 +808,17 @@ static void ndisc_recv_ns(struct sk_buff *skb) have_ifp: if (ifp->flags & (IFA_F_TENTATIVE|IFA_F_OPTIMISTIC)) { if (dad) { +

Re: [PATCH net-next v3] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

2016-12-02 Thread David Miller
From: Erik Nordmark Date: Wed, 30 Nov 2016 15:39:19 -0800 > @@ -794,6 +808,17 @@ static void ndisc_recv_ns(struct sk_buff *skb) > have_ifp: > if (ifp->flags & (IFA_F_TENTATIVE|IFA_F_OPTIMISTIC)) { > if (dad) { > + if (nonce != 0 &&

Re: [PATCH net-next v3] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

2016-12-01 Thread Erik Nordmark
On 12/1/16 2:28 PM, Hannes Frederic Sowa wrote: Reviewed-by: Hannes Frederic Sowa Thanks - I'll add that. Also got a warning from the kbuild test robot for route.c which I'll fix. Thanks! @@ -794,6 +808,17 @@ static void ndisc_recv_ns(struct sk_buff *skb) have_ifp: if (if

Re: [PATCH net-next v3] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

2016-12-01 Thread Hannes Frederic Sowa
On 01.12.2016 00:39, Erik Nordmark wrote: > Implemented RFC7527 Enhanced DAD. > IPv6 duplicate address detection can fail if there is some temporary > loopback of Ethernet frames. RFC7527 solves this by including a random > nonce in the NS messages used for DAD, and if an NS is received with the >

[PATCH net-next v3] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

2016-11-30 Thread Erik Nordmark
Implemented RFC7527 Enhanced DAD. IPv6 duplicate address detection can fail if there is some temporary loopback of Ethernet frames. RFC7527 solves this by including a random nonce in the NS messages used for DAD, and if an NS is received with the same nonce it is assumed to be a looped back DAD pro