Re: [PATCH net-next v3] Add Mellanox BlueField Gigabit Ethernet driver

2020-11-18 Thread Andrew Lunn
> Yes mlxbf_gige_mdio_handle_phy_interrupt is used to check whether > the interrupt is coming from GPIO12 (which is set in HW as the PHY > INT_N pin). There is one HW interrupt line (here defined as > MLXBF_GIGE_PHY_INT_N) shared among all the GPIOs and other > components (like I2C). So this is th

RE: [PATCH net-next v3] Add Mellanox BlueField Gigabit Ethernet driver

2020-11-18 Thread Asmaa Mnebhi
Hi Andrew, > > +static int mlxbf_gige_phy_enable_interrupt(struct phy_device *phydev) > > +{ > > + int err = 0; > > + > > + if (phydev->drv->ack_interrupt) > > + err = phydev->drv->ack_interrupt(phydev); > > + if (err < 0) > > + return err; > > + > > + phydev->interrupt

Re: [PATCH net-next v3] Add Mellanox BlueField Gigabit Ethernet driver

2020-11-17 Thread Andrew Lunn
Hi David > +static int mlxbf_gige_phy_enable_interrupt(struct phy_device *phydev) > +{ > + int err = 0; > + > + if (phydev->drv->ack_interrupt) > + err = phydev->drv->ack_interrupt(phydev); > + if (err < 0) > + return err; > + > + phydev->interrupts = PHY_IN

[PATCH net-next v3] Add Mellanox BlueField Gigabit Ethernet driver

2020-11-17 Thread David Thompson
This patch adds build and driver logic for the "mlxbf_gige" Ethernet driver from Mellanox Technologies. The second generation BlueField SoC from Mellanox supports an out-of-band GigaBit Ethernet management port to the Arm subsystem. This driver supports TCP/IP network connectivity for that port, a