Re: [PATCH net-next v2 5/9] nfp: extend flower matching capabilities

2017-06-29 Thread Simon Horman
On Thu, Jun 29, 2017 at 05:31:22PM +0300, Or Gerlitz wrote: > On Wed, Jun 28, 2017 at 11:29 PM, Simon Horman > wrote: > > + /* Populate IPv4 frame. */ > > + frame->reserved = 0; > > + frame->ipv4_src = flow_ipv4->src; > > + frame->ipv4_dst = flow_ipv4->dst; > > + fram

Re: [PATCH net-next v2 5/9] nfp: extend flower matching capabilities

2017-06-29 Thread Simon Horman
On Thu, Jun 29, 2017 at 05:33:32PM +0300, Or Gerlitz wrote: > On Wed, Jun 28, 2017 at 11:29 PM, Simon Horman > wrote: > > +nfp_flower_compile_meta_tci(struct nfp_flower_meta_two *frame, > > + struct tc_cls_flower_offload *flow, u8 key_type, > > +

Re: [PATCH net-next v2 5/9] nfp: extend flower matching capabilities

2017-06-29 Thread Or Gerlitz
On Wed, Jun 28, 2017 at 11:29 PM, Simon Horman wrote: > +nfp_flower_compile_meta_tci(struct nfp_flower_meta_two *frame, > + struct tc_cls_flower_offload *flow, u8 key_type, > + bool mask_version) what's the role of the mask_version flag here and

Re: [PATCH net-next v2 5/9] nfp: extend flower matching capabilities

2017-06-29 Thread Or Gerlitz
On Wed, Jun 28, 2017 at 11:29 PM, Simon Horman wrote: > + /* Populate IPv4 frame. */ > + frame->reserved = 0; > + frame->ipv4_src = flow_ipv4->src; > + frame->ipv4_dst = flow_ipv4->dst; > + frame->proto = flow_basic->ip_proto; > + /* Wildcard TOS/TTL as TC can't

[PATCH net-next v2 5/9] nfp: extend flower matching capabilities

2017-06-28 Thread Simon Horman
From: Pieter Jansen van Vuuren Extends matching capabilities for flower offloads to include vlan, layer 2, layer 3 and layer 4 type matches. This includes both exact and wildcard matching. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/n