Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

2015-08-20 Thread Pravin Shelar
On Tue, Aug 18, 2015 at 2:12 PM, David Miller wrote: > From: Pravin B Shelar > Date: Mon, 17 Aug 2015 14:11:41 -0700 > >> + if (tun_dst) >> + skb_dst_set(skb, (struct dst_entry *)tun_dst); >> + > > Please don't cast things like this, it is completely unnecessary: > > skb_d

Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

2015-08-20 Thread Pravin Shelar
On Tue, Aug 18, 2015 at 6:07 PM, Jesse Gross wrote: > On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar wrote: >> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >> index 546494d..cb2d874 100644 >> --- a/drivers/net/geneve.c >> +++ b/drivers/net/geneve.c >> +static int geneve_configure(st

Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

2015-08-18 Thread Jesse Gross
On Mon, Aug 17, 2015 at 2:11 PM, Pravin B Shelar wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 546494d..cb2d874 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > +static int geneve_configure(struct net *net, struct net_device *dev, > +

Re: [PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

2015-08-18 Thread David Miller
From: Pravin B Shelar Date: Mon, 17 Aug 2015 14:11:41 -0700 > + if (tun_dst) > + skb_dst_set(skb, (struct dst_entry *)tun_dst); > + Please don't cast things like this, it is completely unnecessary: skb_dst_set(skb, &tun_dst->dst); -- To unsubscribe from this list: send t

[PATCH net-next v2 5/9] geneve: Add support to collect tunnel metadata.

2015-08-17 Thread Pravin B Shelar
Following patch create new tunnel flag which enable tunnel metadata collection on given device. These devices can be used by tunnel metadata based routing or by OVS. Geneve Consolidation patch get rid of collect_md_tun to simplify tunnel lookup further. Signed-off-by: Pravin B Shelar --- drivers