Re: [PATCH net-next v2 5/6] gtp: add socket to pdp context

2017-02-06 Thread Harald Welte
Dear All, On Thu, Feb 02, 2017 at 04:07:23PM +0100, Andreas Schultz wrote: > - On Feb 2, 2017, at 3:46 PM, pablo pa...@netfilter.org wrote: > > On Thu, Feb 02, 2017 at 03:38:07PM +0100, Andreas Schultz wrote: > >> - On Feb 2, 2017, at 3:28 PM, pablo pa...@netfilter.org wrote: > >> > I sugg

Re: [PATCH net-next v2 5/6] gtp: add socket to pdp context

2017-02-02 Thread Andreas Schultz
- On Feb 2, 2017, at 3:46 PM, pablo pa...@netfilter.org wrote: > On Thu, Feb 02, 2017 at 03:38:07PM +0100, Andreas Schultz wrote: >> >> >> - On Feb 2, 2017, at 3:28 PM, pablo pa...@netfilter.org wrote: >> >> > On Thu, Feb 02, 2017 at 03:12:55PM +0100, Andreas Schultz wrote: >> >> Hi,

Re: [PATCH net-next v2 5/6] gtp: add socket to pdp context

2017-02-02 Thread Pablo Neira Ayuso
On Thu, Feb 02, 2017 at 03:38:07PM +0100, Andreas Schultz wrote: > > > - On Feb 2, 2017, at 3:28 PM, pablo pa...@netfilter.org wrote: > > > On Thu, Feb 02, 2017 at 03:12:55PM +0100, Andreas Schultz wrote: > >> Hi, > >> > >> - On Feb 2, 2017, at 2:56 PM, pablo pa...@netfilter.org wrote:

Re: [PATCH net-next v2 5/6] gtp: add socket to pdp context

2017-02-02 Thread Andreas Schultz
- On Feb 2, 2017, at 3:28 PM, pablo pa...@netfilter.org wrote: > On Thu, Feb 02, 2017 at 03:12:55PM +0100, Andreas Schultz wrote: >> Hi, >> >> - On Feb 2, 2017, at 2:56 PM, pablo pa...@netfilter.org wrote: >> >> > On Mon, Jan 30, 2017 at 05:37:12PM +0100, Andreas Schultz wrote: >> >> H

Re: [PATCH net-next v2 5/6] gtp: add socket to pdp context

2017-02-02 Thread Pablo Neira Ayuso
On Thu, Feb 02, 2017 at 03:12:55PM +0100, Andreas Schultz wrote: > Hi, > > - On Feb 2, 2017, at 2:56 PM, pablo pa...@netfilter.org wrote: > > > On Mon, Jan 30, 2017 at 05:37:12PM +0100, Andreas Schultz wrote: > >> Having the socket present in context simplifies the sending logic. > >> It also

Re: [PATCH net-next v2 5/6] gtp: add socket to pdp context

2017-02-02 Thread Andreas Schultz
Hi, - On Feb 2, 2017, at 2:56 PM, pablo pa...@netfilter.org wrote: > On Mon, Jan 30, 2017 at 05:37:12PM +0100, Andreas Schultz wrote: >> Having the socket present in context simplifies the sending logic. >> It also fixes the invalid assumption that we have to use the same >> sending socket fo

Re: [PATCH net-next v2 5/6] gtp: add socket to pdp context

2017-02-02 Thread Pablo Neira Ayuso
On Mon, Jan 30, 2017 at 05:37:12PM +0100, Andreas Schultz wrote: > Having the socket present in context simplifies the sending logic. > It also fixes the invalid assumption that we have to use the same > sending socket for all client IP's on a specific gtp interface. > > Signed-off-by: Andreas Sch

[PATCH net-next v2 5/6] gtp: add socket to pdp context

2017-01-30 Thread Andreas Schultz
Having the socket present in context simplifies the sending logic. It also fixes the invalid assumption that we have to use the same sending socket for all client IP's on a specific gtp interface. Signed-off-by: Andreas Schultz --- drivers/net/gtp.c | 72 ++---