Re: [PATCH net-next v2 4/9] gve: Add support for dma_mask register

2020-09-03 Thread Jakub Kicinski
On Thu, 3 Sep 2020 09:31:16 -0700 David Awogbemila wrote: > Thanks, I'll adjust this. Please don't top post. > On Wed, Sep 2, 2020 at 4:08 PM David Miller wrote: > > > > From: David Awogbemila > > Date: Wed, 2 Sep 2020 11:42:37 -0700 > > > > > I don't think there is a specific 24-bit device i

Re: [PATCH net-next v2 4/9] gve: Add support for dma_mask register

2020-09-02 Thread David Miller
From: David Awogbemila Date: Wed, 2 Sep 2020 11:42:37 -0700 > I don't think there is a specific 24-bit device in mind here, only > that we have seen 32-bit addressing use cases where the guest ran out > of SWIOTLB space and restricting to GFP_DMA32 helped.. so we thought > it would be natural for

Re: [PATCH net-next v2 4/9] gve: Add support for dma_mask register

2020-09-01 Thread Jakub Kicinski
On Tue, 1 Sep 2020 14:51:44 -0700 David Awogbemila wrote: > From: Catherine Sullivan > > Add the dma_mask register and read it to set the dma_masks. > gve_alloc_page will alloc_page with: > GFP_DMA if priv->dma_mask is 24, > GFP_DMA32 if priv->dma_mask is 32. What about Andrew's request to CC