Hi Alexandre,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Alexandre-Belloni/Microsemi-Ocelot-Ethernet-switch-support/20180429-024136
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (De
Hi Alexandre,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Alexandre-Belloni/Microsemi-Ocelot-Ethernet-switch-support/20180429-024136
config: sh-allmodconfig (attached as .config)
compiler: sh4-lin
On 26/04/2018 23:09:15+0200, Andrew Lunn wrote:
> > +/* Checks if the net_device instance given to us originate from our
> > driver. */
> > +static bool ocelot_netdevice_dev_check(const struct net_device *dev)
> > +{
> > + return dev->netdev_ops == &ocelot_port_netdev_ops;
> > +}
>
> This is pr
> +/* Checks if the net_device instance given to us originate from our driver.
> */
> +static bool ocelot_netdevice_dev_check(const struct net_device *dev)
> +{
> + return dev->netdev_ops == &ocelot_port_netdev_ops;
> +}
This is probably O.K. now, but when you add support for controlling
the
