Re: [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

2017-04-16 Thread Roopa Prabhu
On 4/16/17, 8:03 AM, Matthias Schiffer wrote: > On 04/14/2017 07:36 PM, Stephen Hemminger wrote: >> On Fri, 14 Apr 2017 18:44:44 +0200 >> Matthias Schiffer wrote: >> >>> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c >>> index 07f89b037681..95a71546e8f2 100644 >>> --- a/drivers/net/vxlan.c

Re: [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

2017-04-16 Thread Matthias Schiffer
On 04/14/2017 07:36 PM, Stephen Hemminger wrote: > On Fri, 14 Apr 2017 18:44:44 +0200 > Matthias Schiffer wrote: > >> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c >> index 07f89b037681..95a71546e8f2 100644 >> --- a/drivers/net/vxlan.c >> +++ b/drivers/net/vxlan.c >> @@ -2881,11 +2881,39

Re: [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

2017-04-16 Thread Matthias Schiffer
On 04/14/2017 07:27 PM, Sergei Shtylyov wrote: > On 04/14/2017 07:44 PM, Matthias Schiffer wrote: > >> * Multicast addresses are never valid as local address >> * Link-local IPv6 unicast addresses may only be used as remote when the >> local address is link-local as well >> * Don't allow link-lo

Re: [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

2017-04-14 Thread Stephen Hemminger
On Fri, 14 Apr 2017 18:44:44 +0200 Matthias Schiffer wrote: > diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c > index 07f89b037681..95a71546e8f2 100644 > --- a/drivers/net/vxlan.c > +++ b/drivers/net/vxlan.c > @@ -2881,11 +2881,39 @@ static int vxlan_config_validate(struct net *src_net, >

Re: [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

2017-04-14 Thread Sergei Shtylyov
On 04/14/2017 07:44 PM, Matthias Schiffer wrote: * Multicast addresses are never valid as local address * Link-local IPv6 unicast addresses may only be used as remote when the local address is link-local as well * Don't allow link-local IPv6 local/remote addresses without interface We also st

[PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

2017-04-14 Thread Matthias Schiffer
* Multicast addresses are never valid as local address * Link-local IPv6 unicast addresses may only be used as remote when the local address is link-local as well * Don't allow link-local IPv6 local/remote addresses without interface We also store in the flags field if link-local addresses are u