On Fri, 7 Jun 2019 22:27:07 +, Patel, Vedang wrote:
> Hi Jacub,
>
> > On Jun 7, 2019, at 3:02 PM, Jakub Kicinski
> > wrote:
> >
> > On Fri, 7 Jun 2019 20:42:55 +, Patel, Vedang wrote:
> >>> Thanks for the changes, since you now validate no unknown flags are
> >>> passed, perhaps ther
Hi Jacub,
> On Jun 7, 2019, at 3:02 PM, Jakub Kicinski
> wrote:
>
> On Fri, 7 Jun 2019 20:42:55 +, Patel, Vedang wrote:
>>> Thanks for the changes, since you now validate no unknown flags are
>>> passed, perhaps there is no need to check if flags are == ~0?
>>>
>>> IS_ENABLED() could just
On Fri, 7 Jun 2019 20:42:55 +, Patel, Vedang wrote:
> > Thanks for the changes, since you now validate no unknown flags are
> > passed, perhaps there is no need to check if flags are == ~0?
> >
> > IS_ENABLED() could just do: (flags) & TCA_TAPRIO_ATTR_FLAG_TXTIME_ASSIST
> > No?
> >
> This i
Thanks Jacub for the feedback. My comments are inline.
I will wait a few more days for more feedback/discussions on the series and
then post the next version of the series.
> On Jun 6, 2019, at 4:21 PM, Jakub Kicinski
> wrote:
>
> On Thu, 6 Jun 2019 10:50:56 -0700, Vedang Patel wrote:
>> Cu
On Thu, 6 Jun 2019 10:50:56 -0700, Vedang Patel wrote:
> Currently, we are seeing non-critical packets being transmitted outside of
> their timeslice. We can confirm that the packets are being dequeued at the
> right time. So, the delay is induced in the hardware side. The most likely
> reason is
Currently, we are seeing non-critical packets being transmitted outside of
their timeslice. We can confirm that the packets are being dequeued at the
right time. So, the delay is induced in the hardware side. The most likely
reason is the hardware queues are starving the lower priority queues.
In
