Re: [PATCH net-next v2 3/6] smsc95xx: add PAL support to use external PHY drivers

2020-07-25 Thread kernel test robot
Hi Andre, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Andre-Edich/Add-PAL-support-to-smsc95xx/20200723-195824 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7fc3b978a8

Re: [PATCH net-next v2 3/6] smsc95xx: add PAL support to use external PHY drivers

2020-07-24 Thread Andre.Edich
On Fri, 2020-07-24 at 00:39 +0200, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Thu, Jul 23, 2020 at 01:55:04PM +0200, Andre Edich wrote: > > Generally, each PHY has their own configuration and it can be done > > through a

Re: [PATCH net-next v2 3/6] smsc95xx: add PAL support to use external PHY drivers

2020-07-24 Thread Andrew Lunn
> > > +static void smsc95xx_handle_link_change(struct net_device *net) > > > +{ > > > + phy_print_status(net->phydev); > > > > So the MAC does not care about the speed? The pause configuration? > > Duplex? > > Now, I'm wondering how those "care about speed", "pause", and "duplex" > work in th

Re: [PATCH net-next v2 3/6] smsc95xx: add PAL support to use external PHY drivers

2020-07-23 Thread Andrew Lunn
On Thu, Jul 23, 2020 at 01:55:04PM +0200, Andre Edich wrote: > Generally, each PHY has their own configuration and it can be done > through an external PHY driver. The smsc95xx driver uses only the > hard-coded internal PHY configuration. > > This patch adds PAL (PHY Abstraction Layer) support to

[PATCH net-next v2 3/6] smsc95xx: add PAL support to use external PHY drivers

2020-07-23 Thread Andre Edich
Generally, each PHY has their own configuration and it can be done through an external PHY driver. The smsc95xx driver uses only the hard-coded internal PHY configuration. This patch adds PAL (PHY Abstraction Layer) support to probe external PHY drivers for configuring external PHYs. Signed-off-