Re: [PATCH net-next v2 3/3] udp: try to avoid 2 cache miss on dequeue

2017-06-09 Thread David Miller
From: Paolo Abeni Date: Fri, 09 Jun 2017 17:44:29 +0200 > I'll re-submit v3 unchanged, if there are no objections. No objections from me.

Re: [PATCH net-next v2 3/3] udp: try to avoid 2 cache miss on dequeue

2017-06-09 Thread Paolo Abeni
Hi, On Wed, 2017-06-07 at 10:10 -0400, David Miller wrote: > From: Paolo Abeni > Date: Wed, 07 Jun 2017 09:56:45 +0200 > > > Hi David, > > > > On Tue, 2017-06-06 at 16:23 +0200, Paolo Abeni wrote: > >> when udp_recvmsg() is executed, on x86_64 and other archs, most skb > >> fields are on cold c

Re: [PATCH net-next v2 3/3] udp: try to avoid 2 cache miss on dequeue

2017-06-07 Thread David Miller
From: Paolo Abeni Date: Wed, 07 Jun 2017 09:56:45 +0200 > Hi David, > > On Tue, 2017-06-06 at 16:23 +0200, Paolo Abeni wrote: >> when udp_recvmsg() is executed, on x86_64 and other archs, most skb >> fields are on cold cachelines. >> If the skb are linear and the kernel don't need to compute the

Re: [PATCH net-next v2 3/3] udp: try to avoid 2 cache miss on dequeue

2017-06-07 Thread Paolo Abeni
Hi David, On Tue, 2017-06-06 at 16:23 +0200, Paolo Abeni wrote: > when udp_recvmsg() is executed, on x86_64 and other archs, most skb > fields are on cold cachelines. > If the skb are linear and the kernel don't need to compute the udp > csum, only a handful of skb fields are required by udp_recvm

Re: [PATCH net-next v2 3/3] udp: try to avoid 2 cache miss on dequeue

2017-06-06 Thread Eric Dumazet
On Tue, 2017-06-06 at 16:23 +0200, Paolo Abeni wrote: > when udp_recvmsg() is executed, on x86_64 and other archs, most skb > fields are on cold cachelines. > If the skb are linear and the kernel don't need to compute the udp > csum, only a handful of skb fields are required by udp_recvmsg(). > Sin

[PATCH net-next v2 3/3] udp: try to avoid 2 cache miss on dequeue

2017-06-06 Thread Paolo Abeni
when udp_recvmsg() is executed, on x86_64 and other archs, most skb fields are on cold cachelines. If the skb are linear and the kernel don't need to compute the udp csum, only a handful of skb fields are required by udp_recvmsg(). Since we already use skb->dev_scratch to cache hot data, and there