Re: [PATCH net-next v2 3/3] net: dsa: mt7530: Add support for port 5

2019-08-25 Thread René van Dorst
Hi David, Quoting David Miller : From: René van Dorst Date: Wed, 21 Aug 2019 16:45:47 +0200 + dev_info(ds->dev, "Setup P5, HWTRAP=0x%x, intf_sel=%s, phy-mode=%s\n", +val, p5_intf_modes(priv->p5_intf_sel), phy_modes(interface)); This is debugging, at best. Please make

Re: [PATCH net-next v2 3/3] net: dsa: mt7530: Add support for port 5

2019-08-24 Thread David Miller
From: René van Dorst Date: Wed, 21 Aug 2019 16:45:47 +0200 > + dev_info(ds->dev, "Setup P5, HWTRAP=0x%x, intf_sel=%s, phy-mode=%s\n", > + val, p5_intf_modes(priv->p5_intf_sel), phy_modes(interface)); This is debugging, at best. Please make this a debugging message or remove it

[PATCH net-next v2 3/3] net: dsa: mt7530: Add support for port 5

2019-08-21 Thread René van Dorst
Adding support for port 5. Port 5 can muxed/interface to: - internal 5th GMAC of the switch; can be used as 2nd CPU port or as extra port with an external phy for a 6th ethernet port. - internal PHY of port 0 or 4; Used in most applications so that port 0 or 4 is the WAN port and interfaces wi