Re: [PATCH net-next v2 2/6] gtp: merge gtp_get_net and gtp_genl_find_dev

2017-02-13 Thread Pablo Neira Ayuso
On Mon, Feb 13, 2017 at 03:13:37PM +0100, Andreas Schultz wrote: > > > - On Feb 6, 2017, at 2:55 PM, Harald Welte lafo...@netfilter.org wrote: > > > Hi Andreas, > > > > On Mon, Jan 30, 2017 at 05:37:09PM +0100, Andreas Schultz wrote: > >> Both function are always used together with the fina

Re: [PATCH net-next v2 2/6] gtp: merge gtp_get_net and gtp_genl_find_dev

2017-02-13 Thread Andreas Schultz
- On Feb 6, 2017, at 2:55 PM, Harald Welte lafo...@netfilter.org wrote: > Hi Andreas, > > On Mon, Jan 30, 2017 at 05:37:09PM +0100, Andreas Schultz wrote: >> Both function are always used together with the final goal to >> get the gtp_dev. This simplifies the code by merging them together.

Re: [PATCH net-next v2 2/6] gtp: merge gtp_get_net and gtp_genl_find_dev

2017-02-06 Thread Harald Welte
Hi Andreas, On Mon, Jan 30, 2017 at 05:37:09PM +0100, Andreas Schultz wrote: > Both function are always used together with the final goal to > get the gtp_dev. This simplifies the code by merging them together. Ok, some code restructuring / unification, seems useful. However: > -

[PATCH net-next v2 2/6] gtp: merge gtp_get_net and gtp_genl_find_dev

2017-01-30 Thread Andreas Schultz
Both function are always used together with the final goal to get the gtp_dev. This simplifies the code by merging them together. The netdevice lookup is changed to use the regular dev_get_by_index. The gtp netdevice list is now only used to find the PDP contexts for imcomming packets. It can be c