Re: [PATCH net-next v2 2/4] bpf, mlx5: fix various refcount issues in mlx5e_xdp_set

2016-11-17 Thread Daniel Borkmann
On 11/17/2016 10:48 AM, Saeed Mahameed wrote: On Wed, Nov 16, 2016 at 5:26 PM, Daniel Borkmann wrote: On 11/16/2016 03:30 PM, Saeed Mahameed wrote: On Wed, Nov 16, 2016 at 3:54 PM, Daniel Borkmann wrote: On 11/16/2016 01:25 PM, Saeed Mahameed wrote: On Wed, Nov 16, 2016 at 2:04 AM, Daniel B

Re: [PATCH net-next v2 2/4] bpf, mlx5: fix various refcount issues in mlx5e_xdp_set

2016-11-17 Thread Saeed Mahameed
On Wed, Nov 16, 2016 at 5:26 PM, Daniel Borkmann wrote: > On 11/16/2016 03:30 PM, Saeed Mahameed wrote: >> >> On Wed, Nov 16, 2016 at 3:54 PM, Daniel Borkmann >> wrote: >>> >>> On 11/16/2016 01:25 PM, Saeed Mahameed wrote: On Wed, Nov 16, 2016 at 2:04 AM, Daniel Borkmann wrote: >>

Re: [PATCH net-next v2 2/4] bpf, mlx5: fix various refcount issues in mlx5e_xdp_set

2016-11-16 Thread Daniel Borkmann
On 11/16/2016 03:30 PM, Saeed Mahameed wrote: On Wed, Nov 16, 2016 at 3:54 PM, Daniel Borkmann wrote: On 11/16/2016 01:25 PM, Saeed Mahameed wrote: On Wed, Nov 16, 2016 at 2:04 AM, Daniel Borkmann wrote: There are multiple issues in mlx5e_xdp_set(): 1) The batched bpf_prog_add() is current

Re: [PATCH net-next v2 2/4] bpf, mlx5: fix various refcount issues in mlx5e_xdp_set

2016-11-16 Thread Saeed Mahameed
On Wed, Nov 16, 2016 at 3:54 PM, Daniel Borkmann wrote: > On 11/16/2016 01:25 PM, Saeed Mahameed wrote: >> >> On Wed, Nov 16, 2016 at 2:04 AM, Daniel Borkmann >> wrote: >>> >>> There are multiple issues in mlx5e_xdp_set(): >>> >>> 1) The batched bpf_prog_add() is currently not checked for errors!

Re: [PATCH net-next v2 2/4] bpf, mlx5: fix various refcount issues in mlx5e_xdp_set

2016-11-16 Thread Daniel Borkmann
On 11/16/2016 01:25 PM, Saeed Mahameed wrote: On Wed, Nov 16, 2016 at 2:04 AM, Daniel Borkmann wrote: There are multiple issues in mlx5e_xdp_set(): 1) The batched bpf_prog_add() is currently not checked for errors! When doing so, it should be done at an earlier point in time to makes sure

Re: [PATCH net-next v2 2/4] bpf, mlx5: fix various refcount issues in mlx5e_xdp_set

2016-11-16 Thread Saeed Mahameed
On Wed, Nov 16, 2016 at 2:04 AM, Daniel Borkmann wrote: > There are multiple issues in mlx5e_xdp_set(): > > 1) The batched bpf_prog_add() is currently not checked for errors! When >doing so, it should be done at an earlier point in time to makes sure >that we cannot fail anymore at the tim

[PATCH net-next v2 2/4] bpf, mlx5: fix various refcount issues in mlx5e_xdp_set

2016-11-15 Thread Daniel Borkmann
There are multiple issues in mlx5e_xdp_set(): 1) The batched bpf_prog_add() is currently not checked for errors! When doing so, it should be done at an earlier point in time to makes sure that we cannot fail anymore at the time we want to set the program for each channel. This only means