Re: [PATCH net-next v2 2/3] net: ethernet: mediatek: Re-add support SGMII

2019-08-22 Thread Russell King - ARM Linux admin
Hi Rene, On Thu, Aug 22, 2019 at 07:50:33PM +, René van Dorst wrote: > Quoting Russell King - ARM Linux admin : > > Isn't this set for Cisco SGMII as well as for 802.3 1000BASE-X and > > the up-clocked 2500BASE-X modes? > > > > If so, is there a reason why 10Mbps and 100Mbps speeds aren't > >

Re: [PATCH net-next v2 2/3] net: ethernet: mediatek: Re-add support SGMII

2019-08-22 Thread René van Dorst
Hi Russell, Quoting Russell King - ARM Linux admin : On Wed, Aug 21, 2019 at 04:43:35PM +0200, René van Dorst wrote: + if (MTK_HAS_CAPS(mac->hw->soc->caps, MTK_SGMII)) { + if (state->interface != PHY_INTERFACE_MODE_2500BASEX) { phylink_set(mask, 1000

Re: [PATCH net-next v2 2/3] net: ethernet: mediatek: Re-add support SGMII

2019-08-22 Thread Russell King - ARM Linux admin
On Wed, Aug 21, 2019 at 04:43:35PM +0200, René van Dorst wrote: > + if (MTK_HAS_CAPS(mac->hw->soc->caps, MTK_SGMII)) { > + if (state->interface != PHY_INTERFACE_MODE_2500BASEX) { > phylink_set(mask, 1000baseT_Full); > phylink_set(mask, 100

[PATCH net-next v2 2/3] net: ethernet: mediatek: Re-add support SGMII

2019-08-21 Thread René van Dorst
* Re-add SGMII support but now with PHYLINK API support So the SGMII changes are more clear * Move SGMII block setup from mtk_gmac_sgmii_path_setup() to mtk_mac_config() * Merge mtk_setup_hw_path() into mtk_mac_config() * Remove mediatek,physpeed property, fixed-link supports now any speed so