Re: [PATCH net-next v2 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-10-19 Thread Kunihiko Hayashi
On Thu, 19 Oct 2017 09:29:03 +0900 wrote: > 2017-10-18 19:23 GMT+09:00 Kunihiko Hayashi : > > On Mon, 16 Oct 2017 00:08:21 +0900 wrote: > > >> priv->rst = devm_reset_control_get_optional_shared(dev, NULL); > >> if (IS_ERR(priv->rst)) > >> return PTR_ERR(priv->rst); > > > > The clk and

Re: [PATCH net-next v2 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-10-18 Thread Masahiro Yamada
2017-10-18 19:23 GMT+09:00 Kunihiko Hayashi : > On Mon, 16 Oct 2017 00:08:21 +0900 wrote: >> priv->rst = devm_reset_control_get_optional_shared(dev, NULL); >> if (IS_ERR(priv->rst)) >> return PTR_ERR(priv->rst); > > The clk and reset are optional in the driver. > Referring to your sugge

Re: [PATCH net-next v2 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-10-18 Thread Kunihiko Hayashi
On Mon, 16 Oct 2017 00:08:21 +0900 wrote: > 2017-10-13 9:35 GMT+09:00 Kunihiko Hayashi : > > +static int ave_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct device_node *np = dev->of_node; > > + u32 ave_id; > > + struct ave_pr

Re: [PATCH net-next v2 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-10-15 Thread Masahiro Yamada
2017-10-13 9:35 GMT+09:00 Kunihiko Hayashi : > +static int ave_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct device_node *np = dev->of_node; > + u32 ave_id; > + struct ave_private *priv; > + const struct ave_soc_data *data; >

[PATCH net-next v2 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-10-12 Thread Kunihiko Hayashi
The UniPhier platform from Socionext provides the AVE ethernet controller that includes MAC and MDIO bus supporting RGMII/RMII modes. The controller is named AVE. Signed-off-by: Kunihiko Hayashi Signed-off-by: Jassi Brar --- drivers/net/ethernet/Kconfig |1 + drivers/net/etherne