Re: [PATCH net-next v2 2/2] lib8390: Cleanup variables

2020-11-26 Thread Armin Wolf
<20201120120235.1925e...@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> I would indeed like to become the maintainer of this driver, as I do in fact still have working hardware using this code (a Realtek 8029AS). Unfortunately, i am still considering myself too inexperienced in kernel development

Re: [PATCH net-next v2 2/2] lib8390: Cleanup variables

2020-11-20 Thread Jakub Kicinski
On Wed, 18 Nov 2020 17:51:07 +0100 Armin Wolf wrote: > unsigned long e8390_base = dev->base_addr; > struct ei_device *ei_local = netdev_priv(dev); > - int send_length, output_page; > + int output_page; > unsigned long flags; The last two lines should be swapped to follow

[PATCH net-next v2 2/2] lib8390: Cleanup variables

2020-11-18 Thread Armin Wolf
Replace variables associated with the former padding solution with skb->* expressions. They are not needed anymore. Signed-off-by: Armin Wolf --- drivers/net/ethernet/8390/lib8390.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/8390/lib8