RE: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-18 Thread Parav Pandit
> From: David Ahern > Sent: Saturday, September 19, 2020 10:19 AM > > On 9/18/20 10:13 AM, Parav Pandit wrote: > >> You keep adding patches that extend the template based names. Those > >> are going to cause odd EINVAL failures (the absolute worst kind of > >> configuration > >> failure) with n

Re: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-18 Thread David Ahern
On 9/18/20 10:13 AM, Parav Pandit wrote: >> You keep adding patches that extend the template based names. Those are >> going to cause odd EINVAL failures (the absolute worst kind of configuration >> failure) with no way for a user to understand why the command is failing, and >> you need to handle

Re: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-18 Thread Jacob Keller
On 9/17/2020 8:54 PM, Parav Pandit wrote: > > >> From: Jacob Keller >> Sent: Friday, September 18, 2020 12:00 AM >> >> >> On 9/17/2020 10:20 AM, Parav Pandit wrote: >>> A PCI sub-function (SF) represents a portion of the device similar to >>> PCI VF. >>> >>> In an eswitch, PCI SF may have por

RE: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-18 Thread Parav Pandit
Hi David, > From: David Ahern > Sent: Friday, September 18, 2020 8:45 PM > > On 9/17/20 10:18 PM, Parav Pandit wrote: > > > >> From: David Ahern > >> Sent: Friday, September 18, 2020 1:32 AM > >> > >> On 9/17/20 11:20 AM, Parav Pandit wrote: > >>> diff --git a/include/net/devlink.h b/include/ne

Re: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-18 Thread David Ahern
On 9/17/20 10:18 PM, Parav Pandit wrote: > >> From: David Ahern >> Sent: Friday, September 18, 2020 1:32 AM >> >> On 9/17/20 11:20 AM, Parav Pandit wrote: >>> diff --git a/include/net/devlink.h b/include/net/devlink.h index >>> 48b1c1ef1ebd..1edb558125b0 100644 >>> --- a/include/net/devlink.h >>>

RE: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-17 Thread Parav Pandit
> From: David Ahern > Sent: Friday, September 18, 2020 1:32 AM > > On 9/17/20 11:20 AM, Parav Pandit wrote: > > diff --git a/include/net/devlink.h b/include/net/devlink.h index > > 48b1c1ef1ebd..1edb558125b0 100644 > > --- a/include/net/devlink.h > > +++ b/include/net/devlink.h > > @@ -83,6 +83,

RE: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-17 Thread Parav Pandit
> From: Jacob Keller > Sent: Friday, September 18, 2020 12:00 AM > > > On 9/17/2020 10:20 AM, Parav Pandit wrote: > > A PCI sub-function (SF) represents a portion of the device similar to > > PCI VF. > > > > In an eswitch, PCI SF may have port which is normally represented > > using a represen

Re: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-17 Thread David Ahern
On 9/17/20 11:20 AM, Parav Pandit wrote: > diff --git a/include/net/devlink.h b/include/net/devlink.h > index 48b1c1ef1ebd..1edb558125b0 100644 > --- a/include/net/devlink.h > +++ b/include/net/devlink.h > @@ -83,6 +83,20 @@ struct devlink_port_pci_vf_attrs { > u8 external:1; > }; > > +/**

[PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-17 Thread Parav Pandit
A PCI sub-function (SF) represents a portion of the device similar to PCI VF. In an eswitch, PCI SF may have port which is normally represented using a representor netdevice. To have better visibility of eswitch port, its association with SF, and its representor netdevice, introduce a PCI SF port