Re: [PATCH net-next v2 1/5] net: aquantia: Ethtool based ring size configuration

2018-06-04 Thread Igor Russkikh
>> +mutex_lock(&self->aq_mutex); >> + >> if (aq_utils_obj_test(&self->flags, AQ_NIC_FLAGS_IS_NOT_READY)) >> goto err_exit; >> >> @@ -175,6 +177,7 @@ static void aq_nic_service_timer_cb(struct timer_list *t) >> ctimer = max(ctimer / 2, 1); >> >> err_exit: >>

Re: [PATCH net-next v2 1/5] net: aquantia: Ethtool based ring size configuration

2018-06-04 Thread Jakub Kicinski
On Tue, 5 Jun 2018 01:30:15 +0300, Igor Russkikh wrote: > @@ -158,6 +158,8 @@ static void aq_nic_service_timer_cb(struct timer_list *t) > int ctimer = AQ_CFG_SERVICE_TIMER_INTERVAL; > int err = 0; > > + mutex_lock(&self->aq_mutex); > + > if (aq_utils_obj_test(&self->flags,

[PATCH net-next v2 1/5] net: aquantia: Ethtool based ring size configuration

2018-06-04 Thread Igor Russkikh
From: Anton Mikaev Implemented ring size setup, min/max validation and reconfiguration in runtime. NIC level lock is used to prevent collisions on parallel reconfiguration and interference with periodic service timer job. Signed-off-by: Anton Mikaev Signed-off-by: Igor Russkikh --- .../net/et