Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-22 Thread S-k, Shyam-sundar
Hi Heiner On 1/23/2019 12:39 AM, Heiner Kallweit wrote: > On 22.01.2019 15:46, Lendacky, Thomas wrote: >> On 1/21/19 12:36 PM, Heiner Kallweit wrote: >>> On 21.01.2019 17:35, Andrew Lunn wrote: On Sun, Jan 20, 2019 at 10:01:15AM +0100, Heiner Kallweit wrote: > The state machine is a no-op

Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-22 Thread Heiner Kallweit
On 22.01.2019 15:46, Lendacky, Thomas wrote: > On 1/21/19 12:36 PM, Heiner Kallweit wrote: >> On 21.01.2019 17:35, Andrew Lunn wrote: >>> On Sun, Jan 20, 2019 at 10:01:15AM +0100, Heiner Kallweit wrote: The state machine is a no-op before phy_start() has been called. Therefore let's enabl

Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-22 Thread Lendacky, Thomas
On 1/21/19 12:36 PM, Heiner Kallweit wrote: > On 21.01.2019 17:35, Andrew Lunn wrote: >> On Sun, Jan 20, 2019 at 10:01:15AM +0100, Heiner Kallweit wrote: >>> The state machine is a no-op before phy_start() has been called. >>> Therefore let's enable it in phy_start() only. In phy_start() >>> let's

Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-21 Thread Andrew Lunn
On Mon, Jan 21, 2019 at 10:52:48PM +0100, Heiner Kallweit wrote: > On 21.01.2019 19:42, Andrew Lunn wrote: > >> Right. I figured out that I have update phy.txt anyway because I > >> recently removed phy_stop_interrupts which is referenced in the > >> documentation. OK if we leave the patch series a

Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-21 Thread Heiner Kallweit
On 21.01.2019 19:42, Andrew Lunn wrote: >> Right. I figured out that I have update phy.txt anyway because I >> recently removed phy_stop_interrupts which is referenced in the >> documentation. OK if we leave the patch series as is and I submit >> the documentation update as a separate patch? > > H

Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-21 Thread Andrew Lunn
> Right. I figured out that I have update phy.txt anyway because I > recently removed phy_stop_interrupts which is referenced in the > documentation. OK if we leave the patch series as is and I submit > the documentation update as a separate patch? Hi Heiner Fixing the documentation separately is

Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-21 Thread Heiner Kallweit
On 21.01.2019 17:35, Andrew Lunn wrote: > On Sun, Jan 20, 2019 at 10:01:15AM +0100, Heiner Kallweit wrote: >> The state machine is a no-op before phy_start() has been called. >> Therefore let's enable it in phy_start() only. In phy_start() >> let's call phy_start_machine() instead of phy_trigger_ma

Re: [PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-21 Thread Andrew Lunn
On Sun, Jan 20, 2019 at 10:01:15AM +0100, Heiner Kallweit wrote: > The state machine is a no-op before phy_start() has been called. > Therefore let's enable it in phy_start() only. In phy_start() > let's call phy_start_machine() instead of phy_trigger_machine(). > phy_start_machine is an alias for

[PATCH net-next v2 1/4] net: phy: start state machine in phy_start only

2019-01-20 Thread Heiner Kallweit
The state machine is a no-op before phy_start() has been called. Therefore let's enable it in phy_start() only. In phy_start() let's call phy_start_machine() instead of phy_trigger_machine(). phy_start_machine is an alias for phy_trigger_machine but it makes clearer that we start the state machine