Re: [PATCH net-next v2 1/3] net: sched: add mpls manipulation actions to TC

2019-06-17 Thread John Hurley
On Mon, Jun 17, 2019 at 10:18 PM Cong Wang wrote: > > On Fri, Jun 14, 2019 at 3:56 PM John Hurley wrote: > > > > On Fri, Jun 14, 2019 at 5:59 PM Cong Wang wrote: > > > > > > On Thu, Jun 13, 2019 at 10:44 AM John Hurley > > > wrote: > > > > +static inline void tcf_mpls_set_eth_type(struct sk_bu

Re: [PATCH net-next v2 1/3] net: sched: add mpls manipulation actions to TC

2019-06-17 Thread Cong Wang
On Fri, Jun 14, 2019 at 3:56 PM John Hurley wrote: > > On Fri, Jun 14, 2019 at 5:59 PM Cong Wang wrote: > > > > On Thu, Jun 13, 2019 at 10:44 AM John Hurley > > wrote: > > > +static inline void tcf_mpls_set_eth_type(struct sk_buff *skb, __be16 > > > ethertype) > > > +{ > > > + struct eth

Re: [PATCH net-next v2 1/3] net: sched: add mpls manipulation actions to TC

2019-06-14 Thread John Hurley
On Fri, Jun 14, 2019 at 5:59 PM Cong Wang wrote: > > On Thu, Jun 13, 2019 at 10:44 AM John Hurley > wrote: > > +static inline void tcf_mpls_set_eth_type(struct sk_buff *skb, __be16 > > ethertype) > > +{ > > + struct ethhdr *hdr = eth_hdr(skb); > > + > > + skb_postpull_rcsum(skb, &hd

Re: [PATCH net-next v2 1/3] net: sched: add mpls manipulation actions to TC

2019-06-14 Thread Cong Wang
On Thu, Jun 13, 2019 at 10:44 AM John Hurley wrote: > +static inline void tcf_mpls_set_eth_type(struct sk_buff *skb, __be16 > ethertype) > +{ > + struct ethhdr *hdr = eth_hdr(skb); > + > + skb_postpull_rcsum(skb, &hdr->h_proto, ETH_TLEN); > + hdr->h_proto = ethertype; > +

Re: [PATCH net-next v2 1/3] net: sched: add mpls manipulation actions to TC

2019-06-14 Thread John Hurley
On Fri, Jun 14, 2019 at 9:10 AM Jiri Pirko wrote: > > Thu, Jun 13, 2019 at 07:43:57PM CEST, john.hur...@netronome.com wrote: > >Currently, TC offers the ability to match on the MPLS fields of a packet > >through the use of the flow_dissector_key_mpls struct. However, as yet, TC > >actions do not a

Re: [PATCH net-next v2 1/3] net: sched: add mpls manipulation actions to TC

2019-06-14 Thread Jiri Pirko
Thu, Jun 13, 2019 at 07:43:57PM CEST, john.hur...@netronome.com wrote: >Currently, TC offers the ability to match on the MPLS fields of a packet >through the use of the flow_dissector_key_mpls struct. However, as yet, TC >actions do not allow the modification or manipulation of such fields. > >Add

[PATCH net-next v2 1/3] net: sched: add mpls manipulation actions to TC

2019-06-13 Thread John Hurley
Currently, TC offers the ability to match on the MPLS fields of a packet through the use of the flow_dissector_key_mpls struct. However, as yet, TC actions do not allow the modification or manipulation of such fields. Add a new module that registers TC action ops to allow manipulation of MPLS. Thi