Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-13 Thread roopa
On 4/13/16, 5:11 AM, Jamal Hadi Salim wrote: > On 16-04-12 09:21 AM, Thomas Graf wrote: >> On 04/11/16 at 08:53pm, roopa wrote: >>> Top level stats attributes can be netdev or global attributes: We can >>> include string "LINK" in >>> the names of all stats belonging to a netdev to make it easier

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-13 Thread roopa
On 4/13/16, 9:19 PM, David Miller wrote: > From: Roopa Prabhu > Date: Fri, 8 Apr 2016 23:38:11 -0700 > >> This patch adds a new RTM_GETSTATS message to query link stats via netlink >> from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK >> returns a lot more than just stats and is

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-13 Thread David Miller
From: Roopa Prabhu Date: Fri, 8 Apr 2016 23:38:11 -0700 > This patch adds a new RTM_GETSTATS message to query link stats via netlink > from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK > returns a lot more than just stats and is expensive in some cases when > frequent polling

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-13 Thread Jamal Hadi Salim
On 16-04-12 09:21 AM, Thomas Graf wrote: On 04/11/16 at 08:53pm, roopa wrote: Top level stats attributes can be netdev or global attributes: We can include string "LINK" in the names of all stats belonging to a netdev to make it easier to recognize the netdev stats (example): IFLA_STATS_LINK

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-12 Thread Thomas Graf
On 04/11/16 at 08:53pm, roopa wrote: > Top level stats attributes can be netdev or global attributes: We can include > string "LINK" in > the names of all stats belonging to a netdev to make it easier to recognize > the netdev stats (example): > IFLA_STATS_LINK64, (netdev) > IFLA_STAT

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-11 Thread roopa
On 4/10/16, 11:28 AM, roopa wrote: > On 4/10/16, 1:16 AM, Thomas Graf wrote: [snip] >> >> This currently ties everything to a net_device with a selector to >> include certain bits of that net_device. How about we take it half a >> step further and allow for non net_device stats such as IP, TCP, >>

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-10 Thread roopa
On 4/10/16, 6:48 AM, Jamal Hadi Salim wrote: > On 16-04-09 02:00 PM, roopa wrote: > >> This EXTENDED_HW_STATS is for ethtool like extended hw stats. This is >> keeping in >> mind that we want to also move ethtool to netlink in the future and with >> switchdev >> it becomes more necessary that we

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-10 Thread roopa
On 4/10/16, 1:16 AM, Thomas Graf wrote: > On 04/08/16 at 11:38pm, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> This patch adds a new RTM_GETSTATS message to query link stats via netlink >> from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK >> returns a lot more than just stats

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-10 Thread Jamal Hadi Salim
On 16-04-09 02:00 PM, roopa wrote: This EXTENDED_HW_STATS is for ethtool like extended hw stats. This is keeping in mind that we want to also move ethtool to netlink in the future and with switchdev it becomes more necessary that we provide all stats closer to the other netdev stats. So far hw

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-10 Thread Thomas Graf
On 04/08/16 at 11:38pm, Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch adds a new RTM_GETSTATS message to query link stats via netlink > from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK > returns a lot more than just stats and is expensive in some cases when > frequen

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-09 Thread roopa
On 4/9/16, 7:30 AM, Jamal Hadi Salim wrote: > > Thanks for doing the work Roopa and I apologize for late comments > below: > > On 16-04-09 02:38 AM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> > >> This patch also allows for af family stats (an example af stats for IPV6 >> is available with the s

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-09 Thread Jamal Hadi Salim
Thanks for doing the work Roopa and I apologize for late comments below: On 16-04-09 02:38 AM, Roopa Prabhu wrote: From: Roopa Prabhu This patch also allows for af family stats (an example af stats for IPV6 is available with the second patch in the series). Like any other rtnetlink messag

[PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-08 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query link stats via netlink from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some cases when frequent polling for stats from userspace is a common operation