Re: [PATCH net-next v2 1/2] irq_work: Export symbol "irq_work_queue_on"

2020-07-08 Thread Eric Dumazet
On 7/8/20 1:27 PM, Eric Dumazet wrote: > > > On 7/8/20 12:37 PM, David Miller wrote: >> From: "YU, Xiangning" >> Date: Thu, 09 Jul 2020 00:38:16 +0800 >> >>> @@ -111,7 +111,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu) >>> return true; >>> #endif /* CONFIG_SMP */ >>> } >>>

Re: [PATCH net-next v2 1/2] irq_work: Export symbol "irq_work_queue_on"

2020-07-08 Thread YU, Xiangning
On 7/8/20 12:37 PM, David Miller wrote: > From: "YU, Xiangning" > Date: Thu, 09 Jul 2020 00:38:16 +0800 > >> @@ -111,7 +111,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu) >> return true; >> #endif /* CONFIG_SMP */ >> } >> - >> +EXPORT_SYMBOL_GPL(irq_work_queue_on); > > You

Re: [PATCH net-next v2 1/2] irq_work: Export symbol "irq_work_queue_on"

2020-07-08 Thread YU, Xiangning
On 7/8/20 1:27 PM, Eric Dumazet wrote: > > > On 7/8/20 12:37 PM, David Miller wrote: >> From: "YU, Xiangning" >> Date: Thu, 09 Jul 2020 00:38:16 +0800 >> >>> @@ -111,7 +111,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu) >>> return true; >>> #endif /* CONFIG_SMP */ >>> } >>>

Re: [PATCH net-next v2 1/2] irq_work: Export symbol "irq_work_queue_on"

2020-07-08 Thread Eric Dumazet
On 7/8/20 12:37 PM, David Miller wrote: > From: "YU, Xiangning" > Date: Thu, 09 Jul 2020 00:38:16 +0800 > >> @@ -111,7 +111,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu) >> return true; >> #endif /* CONFIG_SMP */ >> } >> - >> +EXPORT_SYMBOL_GPL(irq_work_queue_on); > > You

Re: [PATCH net-next v2 1/2] irq_work: Export symbol "irq_work_queue_on"

2020-07-08 Thread David Miller
From: "YU, Xiangning" Date: Thu, 09 Jul 2020 00:38:16 +0800 > @@ -111,7 +111,7 @@ bool irq_work_queue_on(struct irq_work *work, int cpu) > return true; > #endif /* CONFIG_SMP */ > } > - > +EXPORT_SYMBOL_GPL(irq_work_queue_on); You either removed the need for kthreads or you didn't. If y

Re: [PATCH net-next v2 1/2] irq_work: Export symbol "irq_work_queue_on"

2020-07-08 Thread YU, Xiangning
On 7/8/20 9:55 AM, Eric Dumazet wrote: > > > On 7/8/20 9:38 AM, YU, Xiangning wrote: >> Unlike other irq APIs, irq_work_queue_on is not exported. It makes sense to >> export it so other modules could use it. >> >> Signed-off-by: Xiangning Yu >> --- >> kernel/irq_work.c | 2 +- >> 1 file chan

Re: [PATCH net-next v2 1/2] irq_work: Export symbol "irq_work_queue_on"

2020-07-08 Thread Eric Dumazet
On 7/8/20 9:38 AM, YU, Xiangning wrote: > Unlike other irq APIs, irq_work_queue_on is not exported. It makes sense to > export it so other modules could use it. > > Signed-off-by: Xiangning Yu > --- > kernel/irq_work.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

[PATCH net-next v2 1/2] irq_work: Export symbol "irq_work_queue_on"

2020-07-08 Thread YU, Xiangning
Unlike other irq APIs, irq_work_queue_on is not exported. It makes sense to export it so other modules could use it. Signed-off-by: Xiangning Yu --- kernel/irq_work.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/irq_work.c b/kernel/irq_work.c index eca83965b631..e0e