Re: [PATCH net-next v2 1/2] can-isotp: implement cleanups / improvements from review

2020-10-12 Thread Oliver Hartkopp
On 11.10.20 17:44, Jakub Kicinski wrote: On Sun, 11 Oct 2020 11:24:07 +0200 Oliver Hartkopp wrote: diff --git a/net/can/isotp.c b/net/can/isotp.c index e6ff032b5426..22187669c5c9 100644 --- a/net/can/isotp.c +++ b/net/can/isotp.c @@ -79,6 +79,8 @@ MODULE_LICENSE("Dual BSD/GPL"); MODULE_AUTH

Re: [PATCH net-next v2 1/2] can-isotp: implement cleanups / improvements from review

2020-10-11 Thread kernel test robot
Hi Oliver, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Oliver-Hartkopp/can-isotp-implement-cleanups-improvements-from-review/20201012-55 base: https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH net-next v2 1/2] can-isotp: implement cleanups / improvements from review

2020-10-11 Thread Jakub Kicinski
On Sun, 11 Oct 2020 11:24:07 +0200 Oliver Hartkopp wrote: > @@ -769,7 +771,7 @@ static enum hrtimer_restart isotp_tx_timer_handler(struct > hrtimer *hrtimer) > > isotp_tx_burst: > skb = alloc_skb(so->ll.mtu + sizeof(struct can_skb_priv), > - gfp_any());

Re: [PATCH net-next v2 1/2] can-isotp: implement cleanups / improvements from review

2020-10-11 Thread Jakub Kicinski
On Sun, 11 Oct 2020 11:24:07 +0200 Oliver Hartkopp wrote: > diff --git a/net/can/isotp.c b/net/can/isotp.c > index e6ff032b5426..22187669c5c9 100644 > --- a/net/can/isotp.c > +++ b/net/can/isotp.c > @@ -79,6 +79,8 @@ MODULE_LICENSE("Dual BSD/GPL"); > MODULE_AUTHOR("Oliver Hartkopp "); > MODULE_AL

[PATCH net-next v2 1/2] can-isotp: implement cleanups / improvements from review

2020-10-11 Thread Oliver Hartkopp
As pointed out by Jakub Kicinski here: http://lore.kernel.org/r/20201009175751.5c540...@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com this patch addresses the remarked issues: - remove empty line in comment - remove default=y for CAN_ISOTP in Kconfig - make use of pr_notice_once() - use GFP_KERNEL