Re: [PATCH net-next v2 1/1] net: dsa: fix fixed-link port registration

2019-08-11 Thread Marek Behun
On Sun, 11 Aug 2019 18:16:11 +0300 Vladimir Oltean wrote: > The DSA fixed-link port functionality *has* been converted to phylink. > See: > - > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=0e27921816ad9 > - > https://git.kernel.org/pub/scm/linux/kernel/git/davem

Re: [PATCH net-next v2 1/1] net: dsa: fix fixed-link port registration

2019-08-11 Thread Andrew Lunn
On Sun, Aug 11, 2019 at 04:04:04PM +0200, Marek Behun wrote: > OK guys, something is terribly wrong here. > > I bisected to the commit mentioned (88d6272acaaa), looked around at the > genphy functions, tried adding the link=0 workaround and it did work, > so I though this was the issue. > > What

Re: [PATCH net-next v2 1/1] net: dsa: fix fixed-link port registration

2019-08-11 Thread Vladimir Oltean
Hi Marek, On Sun, 11 Aug 2019 at 17:06, Marek Behun wrote: > > OK guys, something is terribly wrong here. > > I bisected to the commit mentioned (88d6272acaaa), looked around at the > genphy functions, tried adding the link=0 workaround and it did work, > so I though this was the issue. > > What

Re: [PATCH net-next v2 1/1] net: dsa: fix fixed-link port registration

2019-08-11 Thread Marek Behun
I have sent two new patches, each fixing one of the bugs that negated each other. Marek

Re: [PATCH net-next v2 1/1] net: dsa: fix fixed-link port registration

2019-08-11 Thread Marek Behun
OK guys, something is terribly wrong here. I bisected to the commit mentioned (88d6272acaaa), looked around at the genphy functions, tried adding the link=0 workaround and it did work, so I though this was the issue. What I realized now is that before the commit 88d6272acaaa things worked because

Re: [PATCH net-next v2 1/1] net: dsa: fix fixed-link port registration

2019-08-11 Thread Heiner Kallweit
On 11.08.2019 05:39, Andrew Lunn wrote: > On Sun, Aug 11, 2019 at 05:18:57AM +0200, Marek Behún wrote: >> Commit 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in >> genphy_read_status") broke fixed link DSA port registration in >> dsa_port_fixed_link_register_of: the genphy_read_status does no

Re: [PATCH net-next v2 1/1] net: dsa: fix fixed-link port registration

2019-08-11 Thread Sergei Shtylyov
Hello! Just noticed a comment typo... On 11.08.2019 6:18, Marek Behún wrote: Commit 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in genphy_read_status") broke fixed link DSA port registration in dsa_port_fixed_link_register_of: the genphy_read_status does not do what it is supposed to

Re: [PATCH net-next v2 1/1] net: dsa: fix fixed-link port registration

2019-08-10 Thread Andrew Lunn
On Sun, Aug 11, 2019 at 05:18:57AM +0200, Marek Behún wrote: > Commit 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in > genphy_read_status") broke fixed link DSA port registration in > dsa_port_fixed_link_register_of: the genphy_read_status does not do what > it is supposed to and the followi

[PATCH net-next v2 1/1] net: dsa: fix fixed-link port registration

2019-08-10 Thread Marek Behún
Commit 88d6272acaaa ("net: phy: avoid unneeded MDIO reads in genphy_read_status") broke fixed link DSA port registration in dsa_port_fixed_link_register_of: the genphy_read_status does not do what it is supposed to and the following adjust_link is given wrong parameters. This causes a regression o