Re: [PATCH net-next v2 1/1] geneve: add rtnl changelink support

2017-07-20 Thread Pravin Shelar
On Thu, Jul 20, 2017 at 10:42 AM, Girish Moodalbail wrote: > Hello Pravin, > > >>> +/* Quiesces the geneve device data path for both TX and RX. */ >>> +static inline void geneve_quiesce(struct geneve_dev *geneve, >>> + struct geneve_sock **gs4, >>> +

Re: [PATCH net-next v2 1/1] geneve: add rtnl changelink support

2017-07-20 Thread Girish Moodalbail
Hello Pravin, +/* Quiesces the geneve device data path for both TX and RX. */ +static inline void geneve_quiesce(struct geneve_dev *geneve, + struct geneve_sock **gs4, + struct geneve_sock **gs6) +{ + *gs4 = rtnl_dereference(g

Re: [PATCH net-next v2 1/1] geneve: add rtnl changelink support

2017-07-19 Thread Pravin Shelar
On Tue, Jul 18, 2017 at 4:33 PM, Girish Moodalbail wrote: > This patch adds changelink rtnl operation support for geneve devices > and the code changes involve: > > - add geneve_quiesce() which quiesces the geneve device data path > for both TX and RX. This lets us perform the changelink ope

Re: [PATCH net-next v2 1/1] geneve: add rtnl changelink support

2017-07-19 Thread Girish Moodalbail
On 7/19/17 4:51 PM, David Miller wrote: From: Girish Moodalbail Date: Tue, 18 Jul 2017 16:33:06 -0700 +static inline bool geneve_dst_addr_equal(struct ip_tunnel_info *a, ... +static inline void geneve_quiesce(struct geneve_dev *geneve, ... +static inline void geneve_unquiesce(struct ge

Re: [PATCH net-next v2 1/1] geneve: add rtnl changelink support

2017-07-19 Thread David Miller
From: Girish Moodalbail Date: Tue, 18 Jul 2017 16:33:06 -0700 > +static inline bool geneve_dst_addr_equal(struct ip_tunnel_info *a, ... > +static inline void geneve_quiesce(struct geneve_dev *geneve, ... > +static inline void geneve_unquiesce(struct geneve_dev *geneve, Please no inline functio

[PATCH net-next v2 1/1] geneve: add rtnl changelink support

2017-07-18 Thread Girish Moodalbail
This patch adds changelink rtnl operation support for geneve devices and the code changes involve: - add geneve_quiesce() which quiesces the geneve device data path for both TX and RX. This lets us perform the changelink operation atomically w.r.t data path. Also add geneve_unquiesce() t