Re: [PATCH net-next v2 08/12] net: dsa: Add ndo_vlan_rx_{add,kill}_vid implementation

2019-01-30 Thread Vivien Didelot
Hi Florian, On Tue, 29 Jan 2019 16:55:44 -0800, Florian Fainelli wrote: > - if (br_vlan_enabled(dp->bridge_dev)) > + /* Can be called from dsa_slave_port_obj_add() or > + * dsa_slave_vlan_rx_add_vid() > + */ > + if ((dp->bridge_dev && br_vlan_enabled(dp->bridge_dev)) || >

[PATCH net-next v2 08/12] net: dsa: Add ndo_vlan_rx_{add,kill}_vid implementation

2019-01-29 Thread Florian Fainelli
In order to properly support VLAN filtering being enabled/disabled on a bridge, while having other ports being non bridge port members, we need to support the ndo_vlan_rx_{add,kill}_vid callbacks in order to make sure the non-bridge ports can continue receiving VLAN tags, even when the switch is gl