Re: [PATCH net-next v2 06/10] net: dsa: lan9303: added sysfs node swe_bcst_throt

2017-07-27 Thread Jiri Pirko
Thu, Jul 27, 2017 at 03:26:25PM CEST, and...@lunn.ch wrote: >> Yes, this setting can be used to reduce effect of broadcast storms. > >So one way to solve this is to teach the software bridge about >broadcast storm control. Put some rate limiting into its broadcast >flood handling. Then add a switch

Re: [PATCH net-next v2 06/10] net: dsa: lan9303: added sysfs node swe_bcst_throt

2017-07-27 Thread Andrew Lunn
> Yes, this setting can be used to reduce effect of broadcast storms. So one way to solve this is to teach the software bridge about broadcast storm control. Put some rate limiting into its broadcast flood handling. Then add a switchdev call which passes this down into the switch. Or look at doin

Re: [PATCH net-next v2 06/10] net: dsa: lan9303: added sysfs node swe_bcst_throt

2017-07-27 Thread Egil Hjelmeland
On 26. juli 2017 19:14, Andrew Lunn wrote: On Tue, Jul 25, 2017 at 06:15:49PM +0200, Egil Hjelmeland wrote: Allowing per-port access to Switch Engine Broadcast Throttling Register Hi Egil In general, we are against using sysfs. If there is a generic mechanism, that applies for all sorts of ne

Re: [PATCH net-next v2 06/10] net: dsa: lan9303: added sysfs node swe_bcst_throt

2017-07-26 Thread Andrew Lunn
On Tue, Jul 25, 2017 at 06:15:49PM +0200, Egil Hjelmeland wrote: > Allowing per-port access to Switch Engine Broadcast Throttling Register Hi Egil In general, we are against using sysfs. If there is a generic mechanism, that applies for all sorts of network interfaces, it should be used instead o

[PATCH net-next v2 06/10] net: dsa: lan9303: added sysfs node swe_bcst_throt

2017-07-25 Thread Egil Hjelmeland
Allowing per-port access to Switch Engine Broadcast Throttling Register Also added lan9303_write_switch_reg_mask() Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 83 ++ 1 file changed, 83 insertions(+) diff --git a/drivers/net/dsa/la