Re: [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate

2018-01-04 Thread Subash Abhinov Kasiviswanathan
The real device over which the rmnet devices are installed also aggregate multiple IP packets and sends them as a single large aggregate frame to the hardware. It would be nice to give some details about this in the changelog. Also what results you get with different values for the shift (10,

Re: [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate

2018-01-03 Thread Eric Dumazet
On Wed, 2018-01-03 at 15:45 -0700, Subash Abhinov Kasiviswanathan wrote: > > > + sk_pacing_shift_update(skb->sk, 8); > > > > Well... Please tell us why this is needed in this driver. > > > > This interface is meant for wifi aggregation, not to work around some > > strange ethernet drivers designs

Re: [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate

2018-01-03 Thread Subash Abhinov Kasiviswanathan
+ sk_pacing_shift_update(skb->sk, 8); Well... Please tell us why this is needed in this driver. This interface is meant for wifi aggregation, not to work around some strange ethernet drivers designs. Hi Eric The real device over which the rmnet devices are installed also aggregate mult

Re: [PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate

2018-01-03 Thread Eric Dumazet
On Wed, 2018-01-03 at 14:43 -0700, Subash Abhinov Kasiviswanathan wrote: > With a default pacing rate of 10, the uplink data rate for a single > TCP stream is around 10Mbps. Setting it to 8 increases it to 146Mbps > which is the maximum supported transmit rate. > > Signed-off-by: Subash Abhinov Ka

[PATCH net-next v2 05/10] net: qualcomm: rmnet: Set pacing rate

2018-01-03 Thread Subash Abhinov Kasiviswanathan
With a default pacing rate of 10, the uplink data rate for a single TCP stream is around 10Mbps. Setting it to 8 increases it to 146Mbps which is the maximum supported transmit rate. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 3 +++ 1