Re: [PATCH net-next v2 04/16] l2tp: refactor tunnel lifetime handling wrt its socket

2018-02-15 Thread kbuild test robot
Hi James, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/James-Chapman/l2tp-fix-API-races-discovered-by-syzbot/20180215-060031 config: x86_64-rhel (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3

Re: [PATCH net-next v2 04/16] l2tp: refactor tunnel lifetime handling wrt its socket

2018-02-12 Thread Guillaume Nault
On Mon, Feb 12, 2018 at 10:11:08AM +, James Chapman wrote: > Ensure that the tunnel's socket is always extant while the tunnel > object exists. Hold a ref on the socket until the tunnel is destroyed > and ensure that all tunnel destroy paths go through a common function > (l2tp_tunnel_delete).

[PATCH net-next v2 04/16] l2tp: refactor tunnel lifetime handling wrt its socket

2018-02-12 Thread James Chapman
Ensure that the tunnel's socket is always extant while the tunnel object exists. Hold a ref on the socket until the tunnel is destroyed and ensure that all tunnel destroy paths go through a common function (l2tp_tunnel_delete). Since the tunnel's socket is now guaranteed to exist if the tunnel exi