Re: [PATCH net-next v2 04/12] net: sched: flower: track filter deletion with flag

2019-03-04 Thread Stefano Brivio
On Mon, 4 Mar 2019 14:24:05 + Vlad Buslov wrote: > On Fri 01 Mar 2019 at 23:51, Stefano Brivio wrote: > > Hi Vlad, > > > > On Wed, 27 Feb 2019 12:12:18 +0200 > > Vlad Buslov wrote: > > > >> -static bool __fl_delete(struct tcf_proto *tp, struct cls_fl_filter *f, > >> - str

Re: [PATCH net-next v2 04/12] net: sched: flower: track filter deletion with flag

2019-03-04 Thread Vlad Buslov
On Fri 01 Mar 2019 at 23:51, Stefano Brivio wrote: > Hi Vlad, > > On Wed, 27 Feb 2019 12:12:18 +0200 > Vlad Buslov wrote: > >> -static bool __fl_delete(struct tcf_proto *tp, struct cls_fl_filter *f, >> -struct netlink_ext_ack *extack) >> +static int __fl_delete(struct tcf_pr

Re: [PATCH net-next v2 04/12] net: sched: flower: track filter deletion with flag

2019-03-01 Thread Stefano Brivio
Hi Vlad, On Wed, 27 Feb 2019 12:12:18 +0200 Vlad Buslov wrote: > -static bool __fl_delete(struct tcf_proto *tp, struct cls_fl_filter *f, > - struct netlink_ext_ack *extack) > +static int __fl_delete(struct tcf_proto *tp, struct cls_fl_filter *f, > +bool *l

[PATCH net-next v2 04/12] net: sched: flower: track filter deletion with flag

2019-02-27 Thread Vlad Buslov
In order to prevent double deletion of filter by concurrent tasks when rtnl lock is not used for synchronization, add 'deleted' filter field. Check value of this field when modifying filters and return error if concurrent deletion is detected. Refactor __fl_delete() to accept pointer to 'last' boo