Re: [PATCH net-next v2 04/12] gtp: drop unnecessary call to skb_dst_drop

On 12/12/2020 10:50, Harald Welte wrote: On Fri, Dec 11, 2020 at 01:26:04PM +0100, Jonas Bonn wrote: The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). I must be blind, can you please point out where exactly this happens? It's in skb_scrub_packet() which is called by

Re: [PATCH net-next v2 04/12] gtp: drop unnecessary call to skb_dst_drop

On Fri, Dec 11, 2020 at 01:26:04PM +0100, Jonas Bonn wrote: > The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). I must be blind, can you please point out where exactly this happens? I don't see any skb_dst_drop in udp_tunnel_xmit_skb, and in iptunnel_xmit() there's only a

[PATCH net-next v2 04/12] gtp: drop unnecessary call to skb_dst_drop

The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index e4e57c0552ee..04d9de385549 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gt