Mon, Jan 21, 2019 at 12:07:14PM CET, era...@mellanox.com wrote:
>
>
>On 1/20/2019 8:45 PM, David Miller wrote:
>> From: Jiri Pirko
>> Date: Sun, 20 Jan 2019 12:08:50 +0100
>>
>>> I haven't have time to review this due to travel. I think it was mistake
>>> to merge this as the buffer api is wrong
On 1/20/2019 8:45 PM, David Miller wrote:
> From: Jiri Pirko
> Date: Sun, 20 Jan 2019 12:08:50 +0100
>
>> I haven't have time to review this due to travel. I think it was mistake
>> to merge this as the buffer api is wrong in my opinion. I would vote for
>> revert if possible.
>
> Let's spend
From: Jiri Pirko
Date: Sun, 20 Jan 2019 12:08:50 +0100
> I haven't have time to review this due to travel. I think it was mistake
> to merge this as the buffer api is wrong in my opinion. I would vote for
> revert if possible.
Let's spend a couple days trying to fix things up first.
I cannot ma
Thu, Jan 17, 2019 at 10:59:10PM CET, era...@mellanox.com wrote:
>Devlink health buffer is a mechanism to pass descriptors between drivers
>and devlink. The API allows the driver to add objects, object pair,
>value array (nested attributes), value and name.
>
>Driver can use this API to fill the buf
Sun, Jan 20, 2019 at 12:06:18PM CET, era...@mellanox.com wrote:
>
>
>On 1/20/2019 12:03 PM, Jiri Pirko wrote:
>> Thu, Jan 17, 2019 at 10:59:10PM CET, era...@mellanox.com wrote:
>>
>> [...]
>>
>>> +static void
>>> +devlink_health_buffers_destroy(struct devlink_health_buffer **buffers_list,
>>> +
On 1/20/2019 12:03 PM, Jiri Pirko wrote:
> Thu, Jan 17, 2019 at 10:59:10PM CET, era...@mellanox.com wrote:
>
> [...]
>
>> +static void
>> +devlink_health_buffers_destroy(struct devlink_health_buffer **buffers_list,
>> + u64 size);
>
> Avoid fwd declarations.
>
>
>>
Thu, Jan 17, 2019 at 10:59:10PM CET, era...@mellanox.com wrote:
[...]
>+static void
>+devlink_health_buffers_destroy(struct devlink_health_buffer **buffers_list,
>+ u64 size);
Avoid fwd declarations.
>+
>+static struct devlink_health_buffer **
>+devlink_health_buffe
Devlink health buffer is a mechanism to pass descriptors between drivers
and devlink. The API allows the driver to add objects, object pair,
value array (nested attributes), value and name.
Driver can use this API to fill the buffers in a format which can be
translated by the devlink to the netlin
