Re: [PATCH net-next v2 00/10] udp_tunnel: add NIC RX port offload infrastructure

2020-07-09 Thread Jakub Kicinski
On Thu, 9 Jul 2020 19:33:11 -0700 Tom Herbert wrote: > The patch set looks good for its purpose, but, sorry, I can't resist > another round of complaining about vendors that continue to develop > protocol specific offloads instead of moving to protocol agnostic > generic offloads. I agree with all

Re: [PATCH net-next v2 00/10] udp_tunnel: add NIC RX port offload infrastructure

2020-07-09 Thread Tom Herbert
The patch set looks good for its purpose, but, sorry, I can't resist another round of complaining about vendors that continue to develop protocol specific offloads instead of moving to protocol agnostic generic offloads. On Wed, Jul 8, 2020 at 6:19 PM Jakub Kicinski wrote: > > Kernel has a facili

Re: [PATCH net-next v2 00/10] udp_tunnel: add NIC RX port offload infrastructure

2020-07-09 Thread Jakub Kicinski
On Thu, 09 Jul 2020 11:23:46 -0700 (PDT) David Miller wrote: > Looks like we get a build failure if IPV4=n and ETHTOOL_NL=y because > the code unconditionally references the udp tunnel ops from the > ethtool tunnel stuff. I see :S I think I'll cut out the entire ETHTOOL_MSG_TUNNEL_INFO_GET suppo

Re: [PATCH net-next v2 00/10] udp_tunnel: add NIC RX port offload infrastructure

2020-07-09 Thread David Miller
Looks like we get a build failure if IPV4=n and ETHTOOL_NL=y because the code unconditionally references the udp tunnel ops from the ethtool tunnel stuff.

[PATCH net-next v2 00/10] udp_tunnel: add NIC RX port offload infrastructure

2020-07-08 Thread Jakub Kicinski
Kernel has a facility to notify drivers about the UDP tunnel ports so that devices can recognize tunneled packets. This is important mostly for RX - devices which don't support CHECKSUM_COMPLETE can report checksums of inner packets, and compute RSS over inner headers. Some drivers also match the U