On Fri, 2020-09-11 at 16:28 -0700, Jakub Kicinski wrote:
> Hi!
>
> This is the first (small) series which exposes some stats via
> the corresponding ethtool interface. Here (thanks to the
> excitability of netlink) we expose pause frame stats via
> the same interfaces as ethtool -a / -A.
>
> In p
On Mon, 14 Sep 2020 19:28:29 +0200 Andrew Lunn wrote:
> On Mon, Sep 14, 2020 at 09:15:18AM -0700, Jakub Kicinski wrote:
> > On Sat, 12 Sep 2020 10:16:12 +0300 Vladimir Oltean wrote:
> > I never used a DSA device. But I was under the impression they were
> > supposed to be modeled like separate NICs
On Mon, 14 Sep 2020 19:36:50 +0200 Andrew Lunn wrote:
> > > Can we consider using get_ethtool_stats and ETH_SS_PAUSE_STATS as a
> > > stringset identifier? That way there is a single point within driver to
> > > fetch stats.
> >
> > Can you say more? There are no strings reported in this patch
> > Can we consider using get_ethtool_stats and ETH_SS_PAUSE_STATS as a
> > stringset identifier? That way there is a single point within driver to
> > fetch stats.
>
> Can you say more? There are no strings reported in this patch set.
Let me ask another question. Is pause stats the end of the
On Mon, Sep 14, 2020 at 09:15:18AM -0700, Jakub Kicinski wrote:
> On Sat, 12 Sep 2020 10:16:12 +0300 Vladimir Oltean wrote:
> I never used a DSA device. But I was under the impression they were
> supposed to be modeled like separate NICs..
The front panel ports are. However there are other types o
On Mon, 14 Sep 2020 09:25:44 -0700 Florian Fainelli wrote:
> >> Can we consider using get_ethtool_stats and ETH_SS_PAUSE_STATS as a
> >> stringset identifier? That way there is a single point within driver to
> >> fetch stats.
> >
> > Can you say more? There are no strings reported in this patch
On Mon, 14 Sep 2020 04:08:14 +0200 Andrew Lunn wrote:
> > DSA used to override the "ethtool -S" callback of the host port, and
> > append its own CPU port counters to that.
>
> That was always a hack. It was bound to break sooner or later.
>
> Ido planned to add statistics to devlink. I hope we
On 9/14/2020 8:53 AM, Jakub Kicinski wrote:
On Fri, 11 Sep 2020 19:54:11 -0700 Florian Fainelli wrote:
I think I'm missing the problem you're trying to describe.
Are you making a general comment / argument on ethtool stats?
Pause stats are symmetrical - as can be seen in your quote
what's RX
On Sat, 12 Sep 2020 10:16:12 +0300 Vladimir Oltean wrote:
> > You can still append your custom CPU port stats to ethtool -S or
> > debugfs or whatnot,
>
> I don't understand, so you're saying that DSA can keep pause stats
> reporting in "ethtool -S", but the rest of devices should move to
> "eth
On Fri, 11 Sep 2020 19:54:11 -0700 Florian Fainelli wrote:
> > I think I'm missing the problem you're trying to describe.
> > Are you making a general comment / argument on ethtool stats?
> >
> > Pause stats are symmetrical - as can be seen in your quote
> > what's RX for the CPU is TX for the swi
> DSA used to override the "ethtool -S" callback of the host port, and
> append its own CPU port counters to that.
That was always a hack. It was bound to break sooner or later.
Ido planned to add statistics to devlink. I hope we can make use of
that to replace the CPU port statistics, and also a
On Fri, Sep 11, 2020 at 05:42:46PM -0700, Jakub Kicinski wrote:
> > The ethtool -S framework was nice because you could append to the
> > counters of the master interface while not losing them.
> > As for "ethtool -A", those parameters are fixed as part of the
> > fixed-link device tree node corres
On 9/11/2020 5:42 PM, Jakub Kicinski wrote:
On Sat, 12 Sep 2020 03:15:42 +0300 Vladimir Oltean wrote:
On Fri, Sep 11, 2020 at 05:07:24PM -0700, Jakub Kicinski wrote:
On Sat, 12 Sep 2020 02:49:32 +0300 Vladimir Oltean wrote:
On Fri, Sep 11, 2020 at 04:28:45PM -0700, Jakub Kicinski wrote:
Hi
On Sat, 12 Sep 2020 03:15:42 +0300 Vladimir Oltean wrote:
> On Fri, Sep 11, 2020 at 05:07:24PM -0700, Jakub Kicinski wrote:
> > On Sat, 12 Sep 2020 02:49:32 +0300 Vladimir Oltean wrote:
> > > On Fri, Sep 11, 2020 at 04:28:45PM -0700, Jakub Kicinski wrote:
> > > > Hi!
> > > >
> > > > This is the
On Fri, Sep 11, 2020 at 05:07:24PM -0700, Jakub Kicinski wrote:
> On Sat, 12 Sep 2020 02:49:32 +0300 Vladimir Oltean wrote:
> > On Fri, Sep 11, 2020 at 04:28:45PM -0700, Jakub Kicinski wrote:
> > > Hi!
> > >
> > > This is the first (small) series which exposes some stats via
> > > the corresponding
On Sat, 12 Sep 2020 02:49:32 +0300 Vladimir Oltean wrote:
> On Fri, Sep 11, 2020 at 04:28:45PM -0700, Jakub Kicinski wrote:
> > Hi!
> >
> > This is the first (small) series which exposes some stats via
> > the corresponding ethtool interface. Here (thanks to the
> > excitability of netlink) we exp
On Fri, Sep 11, 2020 at 04:28:45PM -0700, Jakub Kicinski wrote:
> Hi!
>
> This is the first (small) series which exposes some stats via
> the corresponding ethtool interface. Here (thanks to the
> excitability of netlink) we expose pause frame stats via
> the same interfaces as ethtool -a / -A.
>
Hi!
This is the first (small) series which exposes some stats via
the corresponding ethtool interface. Here (thanks to the
excitability of netlink) we expose pause frame stats via
the same interfaces as ethtool -a / -A.
In particular the following stats from the standard:
- 30.3.4.2 aPAUSEMACCtr
18 matches
Mail list logo
