Re: [PATCH net-next v2 0/5] bridge: per-vlan stats

2016-04-29 Thread Nikolay Aleksandrov
On 04/29/2016 10:12 PM, David Miller wrote: > From: Nikolay Aleksandrov > Date: Fri, 29 Apr 2016 21:49:17 +0200 > >> Because that is not needed for the per-vlan stats to work, I did to >> unify the paths and simplify the pvid code but I can easily drop it >> and revert back to using the direct pv

Re: [PATCH net-next v2 0/5] bridge: per-vlan stats

2016-04-29 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 29 Apr 2016 21:49:17 +0200 > Because that is not needed for the per-vlan stats to work, I did to > unify the paths and simplify the pvid code but I can easily drop it > and revert back to using the direct pvid id. The only fetch will be > the stats per-cpu po

Re: [PATCH net-next v2 0/5] bridge: per-vlan stats

2016-04-29 Thread Nikolay Aleksandrov
On 04/29/2016 09:33 PM, David Miller wrote: > From: Nikolay Aleksandrov > Date: Thu, 28 Apr 2016 17:52:46 +0200 > >> This set adds support for bridge per-vlan statistics. > > Between the counter bumps in fast paths and new levels of pointer > indirection in order to RCU things, I have to agree w

Re: [PATCH net-next v2 0/5] bridge: per-vlan stats

2016-04-29 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 28 Apr 2016 17:52:46 +0200 > This set adds support for bridge per-vlan statistics. Between the counter bumps in fast paths and new levels of pointer indirection in order to RCU things, I have to agree with Stephen that this new overhead is really pushing it.

[PATCH net-next v2 0/5] bridge: per-vlan stats

2016-04-28 Thread Nikolay Aleksandrov
Hi, This set adds support for bridge per-vlan statistics. In order to be able to dump statistics for many vlans we need a way to continue dumping after reaching maximum size, thus patches 01 and 02 extend the new stats API with a per-device extended link stats attribute and callback which can save