Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-08-07 Thread Jamal Hadi Salim
On 2020-07-10 8:04 a.m., Jamal Hadi Salim wrote: On 2020-07-09 8:19 a.m., Jiri Pirko wrote: Thu, Jul 09, 2020 at 01:00:26PM CEST, j...@mojatatu.com wrote: Main point is: classifying based on hash(and for that matter any other metadata like mark) is needed as a general utility for the system

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-10 Thread Jamal Hadi Salim
On 2020-07-09 8:19 a.m., Jiri Pirko wrote: Thu, Jul 09, 2020 at 01:00:26PM CEST, j...@mojatatu.com wrote: On 2020-07-08 10:45 a.m., Jiri Pirko wrote: Wed, Jul 08, 2020 at 03:54:14PM CEST, j...@mojatatu.com wrote: On 2020-07-07 6:05 a.m., Jiri Pirko wrote: Nothing to do with how a driver off

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-09 Thread Ariel Levkovich
Not sure it was sent so trying again... On 7/5/20 8:28 PM, Cong Wang wrote: On Sun, Jul 5, 2020 at 2:50 PM Jamal Hadi Salim wrote: BTW, nothing in skbedit is against computing what the new metadata should be. Yup. IMO: A good arguement to not make it part of skbedit is if it adds unnecessa

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-09 Thread Jiri Pirko
Thu, Jul 09, 2020 at 01:00:26PM CEST, j...@mojatatu.com wrote: >On 2020-07-08 10:45 a.m., Jiri Pirko wrote: >> Wed, Jul 08, 2020 at 03:54:14PM CEST, j...@mojatatu.com wrote: >> > On 2020-07-07 6:05 a.m., Jiri Pirko wrote: > > >[..] >> > IMO: >> > For this specific case where _offload_ is the main u

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-09 Thread Jamal Hadi Salim
On 2020-07-08 10:45 a.m., Jiri Pirko wrote: Wed, Jul 08, 2020 at 03:54:14PM CEST, j...@mojatatu.com wrote: On 2020-07-07 6:05 a.m., Jiri Pirko wrote: [..] IMO: For this specific case where _offload_ is the main use case i think it is not a good idea because flower on ingress is slow. Eh? W

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-08 Thread Jiri Pirko
Wed, Jul 08, 2020 at 03:54:14PM CEST, j...@mojatatu.com wrote: >On 2020-07-07 6:05 a.m., Jiri Pirko wrote: >> Fri, Jul 03, 2020 at 01:22:47PM CEST, j...@mojatatu.com wrote: >> > Hi, >> > >> > Several comments: >> > 1) I agree with previous comments that you should >> > look at incorporating this i

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-08 Thread Jamal Hadi Salim
On 2020-07-07 6:05 a.m., Jiri Pirko wrote: Fri, Jul 03, 2020 at 01:22:47PM CEST, j...@mojatatu.com wrote: Hi, Several comments: 1) I agree with previous comments that you should look at incorporating this into skbedit. Unless incorporating into skbedit introduces huge complexity, IMO it belongs

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-07 Thread Jiri Pirko
Fri, Jul 03, 2020 at 01:22:47PM CEST, j...@mojatatu.com wrote: >Hi, > >Several comments: >1) I agree with previous comments that you should >look at incorporating this into skbedit. >Unless incorporating into skbedit introduces huge >complexity, IMO it belongs there. > >2) I think it would make sen

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-05 Thread Cong Wang
On Sun, Jul 5, 2020 at 2:50 PM Jamal Hadi Salim wrote: > BTW, nothing in skbedit is against computing what the new metadata > should be. Yup. > > IMO: A good arguement to not make it part of skbedit is if it adds > unnecessary complexity to skbedit or policy definitions. > TCA_HASH_ALG_L4 liter

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-05 Thread Cong Wang
On Sun, Jul 5, 2020 at 10:26 AM Ariel Levkovich wrote: > However I believe that from a concept point of view, using it is wrong. > > In my honest opinion, the concept here is to perform some calculation on > the packet itself and its headers while the skb->hash field > > is the storage location of

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-05 Thread Jamal Hadi Salim
Hi Ariel, On 2020-07-05 1:26 p.m., Ariel Levkovich wrote: On 7/3/20 7:22 AM, Jamal Hadi Salim wrote: [..] Hi Jamal, I agree that using skbedit makes some sense and can provide the same functionality. However I believe that from a concept point of view, using it is wrong. In my honest opi

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-05 Thread Ariel Levkovich
On 7/3/20 7:22 AM, Jamal Hadi Salim wrote: Hi, Several comments: 1) I agree with previous comments that you should look at incorporating this into skbedit. Unless incorporating into skbedit introduces huge complexity, IMO it belongs there. Hi Jamal, I agree that using skbedit makes some sen

Re: [PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-03 Thread Jamal Hadi Salim
Hi, Several comments: 1) I agree with previous comments that you should look at incorporating this into skbedit. Unless incorporating into skbedit introduces huge complexity, IMO it belongs there. 2) I think it would make sense to create a skb hash classifier instead of tying this entirely to fl

[PATCH net-next v2 0/3] ] TC datapath hash api

2020-07-01 Thread Ariel Levkovich
Supporting datapath hash allows user to set up rules that provide load balancing of traffic across multiple vports and for ECMP path selection while keeping the number of rule at minimum. Instead of matching on exact flow spec, which requires a rule per flow, user can define rules based on hashing