Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2021-01-04 Thread Andrew Lunn
On Mon, Jan 04, 2021 at 05:24:11PM +0200, Vladyslav Tarasiuk wrote: > > On 30-Dec-20 17:36, Andrew Lunn wrote: > > On Wed, Dec 30, 2020 at 03:55:02PM +0200, Vladyslav Tarasiuk wrote: > > > On 29-Dec-20 18:25, Andrew Lunn wrote: > > > > > Hi Andrew, > > > > > > > > > > Following this conversation,

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2021-01-04 Thread Vladyslav Tarasiuk
On 30-Dec-20 17:36, Andrew Lunn wrote: On Wed, Dec 30, 2020 at 03:55:02PM +0200, Vladyslav Tarasiuk wrote: On 29-Dec-20 18:25, Andrew Lunn wrote: Hi Andrew, Following this conversation, I wrote some pseudocode checking if I'm on right path here. Please review: struct eeprom_page {    

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-12-30 Thread Andrew Lunn
On Wed, Dec 30, 2020 at 03:55:02PM +0200, Vladyslav Tarasiuk wrote: > > On 29-Dec-20 18:25, Andrew Lunn wrote: > > > Hi Andrew, > > > > > > Following this conversation, I wrote some pseudocode checking if I'm on > > > right path here. > > > Please review: > > > > > > struct eeprom_page { > > >

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-12-30 Thread Vladyslav Tarasiuk
On 29-Dec-20 18:25, Andrew Lunn wrote: Hi Andrew, Following this conversation, I wrote some pseudocode checking if I'm on right path here. Please review: struct eeprom_page {     u8 page_number;     u8 bank_number;     u16 offset;     u16 data_length;     u8 *data; }

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-12-29 Thread Andrew Lunn
> Hi Andrew, > > Following this conversation, I wrote some pseudocode checking if I'm on > right path here. > Please review: > > struct eeprom_page { >     u8 page_number; >     u8 bank_number; >     u16 offset; >     u16 data_length; >     u8 *data; > } I'm wondering about o

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-12-29 Thread Vladyslav Tarasiuk
On 27-Nov-20 17:56, Andrew Lunn wrote: OK, but if the caching system is checking one time netlink and one time ioctl, it means this cache should be in user space, or did you mean to have this cache in kernel ? This is all in userspace, in the ethtool code. What about the global offset that w

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-11-27 Thread Andrew Lunn
> OK, but if the caching system is checking one time netlink and one time > ioctl, it means this cache should be in user space, or did you mean to have > this cache in kernel ? This is all in userspace, in the ethtool code. > > > What about the global offset that we currently got when user doesn'

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-11-27 Thread Moshe Shemesh
On 11/26/2020 5:21 PM, Andrew Lunn wrote: If i was implementing the ethtool side of it, i would probably do some sort of caching system. We know page 0 should always exist, so pre-load that into the cache. Try the netlink API first. If that fails, use the ioctl interface. If the ioctl is used,

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-11-26 Thread Andrew Lunn
> > If i was implementing the ethtool side of it, i would probably do some > > sort of caching system. We know page 0 should always exist, so > > pre-load that into the cache. Try the netlink API first. If that > > fails, use the ioctl interface. If the ioctl is used, put everything > > returned in

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-11-26 Thread Moshe Shemesh
On 11/25/2020 4:18 PM, Andrew Lunn wrote: External email: Use caution opening links or attachments OK, we will add API options to select bank and page to read any specific page the user selects. So advanced user will use it get the optional pages he needs, but what about non advanced user wh

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-11-25 Thread Andrew Lunn
> OK, we will add API options to select bank and page to read any specific > page the user selects. So advanced user will use it get the optional pages > he needs, but what about non advanced user who wants to use the current API > with a current script for DSFP EEPROM. Isn't it better that he will

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-11-25 Thread Moshe Shemesh
On 11/24/2020 11:16 PM, Jakub Kicinski wrote: On Tue, 24 Nov 2020 02:14:59 +0100 Andrew Lunn wrote: On Mon, Nov 23, 2020 at 11:19:56AM +0200, Moshe Shemesh wrote: Add support for new cable module type DSFP (Dual Small Form-Factor Pluggable transceiver). DSFP EEPROM memory layout is compatible

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-11-24 Thread Jakub Kicinski
On Tue, 24 Nov 2020 02:14:59 +0100 Andrew Lunn wrote: > On Mon, Nov 23, 2020 at 11:19:56AM +0200, Moshe Shemesh wrote: > > Add support for new cable module type DSFP (Dual Small Form-Factor Pluggable > > transceiver). DSFP EEPROM memory layout is compatible with CMIS 4.0 spec. > > Add > > CMIS 4.0

Re: [PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-11-23 Thread Andrew Lunn
On Mon, Nov 23, 2020 at 11:19:56AM +0200, Moshe Shemesh wrote: > Add support for new cable module type DSFP (Dual Small Form-Factor Pluggable > transceiver). DSFP EEPROM memory layout is compatible with CMIS 4.0 spec. Add > CMIS 4.0 module type to UAPI and implement DSFP EEPROM dump in mlx5. So th

[PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-11-23 Thread Moshe Shemesh
Add support for new cable module type DSFP (Dual Small Form-Factor Pluggable transceiver). DSFP EEPROM memory layout is compatible with CMIS 4.0 spec. Add CMIS 4.0 module type to UAPI and implement DSFP EEPROM dump in mlx5. Change log: v1 -> v2 - Added comments on accessing only the mandatory part