RE: [PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size calculation

2015-10-14 Thread Arad, Ronen
>-Original Message- >From: David Miller [mailto:da...@davemloft.net] >Sent: Wednesday, October 14, 2015 7:24 PM >To: Arad, Ronen >Cc: netdev@vger.kernel.org >Subject: Re: [PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size >calculation > >From: Ronen Arad

Re: [PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size calculation

2015-10-14 Thread David Miller
From: Ronen Arad Date: Wed, 14 Oct 2015 08:51:28 -0700 > @@ -900,7 +901,7 @@ static noinline size_t if_nlmsg_size(const struct > net_device *dev, > + rtnl_vfinfo_size(dev, ext_filter_mask) /* IFLA_VFINFO_LIST */ > + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS

[PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size calculation

2015-10-14 Thread Ronen Arad
This is a v2 of a 4-parts patch with same subject. Giving up on backward compatibility allows for much simplified single patch. if_nlmsg_size() overestimates the minimum allocation size of netlink dump request (when called from rtnl_calcit()) or the size of the message (when called from rtnl_getli