Re: [PATCH net-next v2] net: vlan: Avoid using BUG() in vlan_proto_idx()

2020-09-27 Thread Florian Fainelli
On 9/25/2020 2:20 PM, Vladimir Oltean wrote: On Fri, Sep 25, 2020 at 02:12:34PM -0700, David Miller wrote: From: Florian Fainelli Date: Thu, 24 Sep 2020 17:27:44 -0700 Applied, thanks Florian. Uh-oh, that 'negative value stored in unsigned variable' issue that the build bot reported was o

Re: [PATCH net-next v2] net: vlan: Avoid using BUG() in vlan_proto_idx()

2020-09-25 Thread Vladimir Oltean
On Fri, Sep 25, 2020 at 02:12:34PM -0700, David Miller wrote: > From: Florian Fainelli > Date: Thu, 24 Sep 2020 17:27:44 -0700 > > Applied, thanks Florian. Uh-oh, that 'negative value stored in unsigned variable' issue that the build bot reported was on v2, wasn't it?

Re: [PATCH net-next v2] net: vlan: Avoid using BUG() in vlan_proto_idx()

2020-09-25 Thread David Miller
From: Florian Fainelli Date: Thu, 24 Sep 2020 17:27:44 -0700 > While we should always make sure that we specify a valid VLAN protocol > to vlan_proto_idx(), killing the machine when an invalid value is > specified is too harsh and not helpful for debugging. All callers are > capable of dealing wi

[PATCH net-next v2] net: vlan: Avoid using BUG() in vlan_proto_idx()

2020-09-24 Thread Florian Fainelli
While we should always make sure that we specify a valid VLAN protocol to vlan_proto_idx(), killing the machine when an invalid value is specified is too harsh and not helpful for debugging. All callers are capable of dealing with an error returned by vlan_proto_idx() so check the index value and p