RE: [PATCH net-next v2] net: sched: fix skb leak in dev_requeue_skb()

2017-12-27 Thread weiyongjun (A)
On 12/27/2017 1:24 PM, John Fastabend wrote: > On 12/24/2017 07:49 PM, Wei Yongjun wrote: > > When dev_requeue_skb() is called with bluked skb list, only the > > first skb of the list will be requeued to qdisc layer, and leak > > the others without free them. > > > > TCP is broken due to skb leak s

Re: [PATCH net-next v2] net: sched: fix skb leak in dev_requeue_skb()

2017-12-26 Thread John Fastabend
On 12/24/2017 07:49 PM, Wei Yongjun wrote: > When dev_requeue_skb() is called with bluked skb list, only the > first skb of the list will be requeued to qdisc layer, and leak > the others without free them. > > TCP is broken due to skb leak since no free skb will be considered > as still in the ho

[PATCH net-next v2] net: sched: fix skb leak in dev_requeue_skb()

2017-12-24 Thread Wei Yongjun
When dev_requeue_skb() is called with bluked skb list, only the first skb of the list will be requeued to qdisc layer, and leak the others without free them. TCP is broken due to skb leak since no free skb will be considered as still in the host queue and never be retransmitted. This happend when