Re: [PATCH net-next v2] net: sched: change tcf_del_walker() to take idrinfo->lock

2018-09-14 Thread Cong Wang
On Fri, Sep 14, 2018 at 3:46 AM Vlad Buslov wrote: > > > On Thu 13 Sep 2018 at 17:13, Cong Wang wrote: > > On Wed, Sep 12, 2018 at 1:51 AM Vlad Buslov wrote: > >> > >> > >> On Fri 07 Sep 2018 at 19:12, Cong Wang wrote: > >> > On Fri, Sep 7, 2018 at 6:52 AM Vlad Buslov wrote: > >> >> > >> >> Ac

Re: [PATCH net-next v2] net: sched: change tcf_del_walker() to take idrinfo->lock

2018-09-14 Thread Vlad Buslov
On Thu 13 Sep 2018 at 17:13, Cong Wang wrote: > On Wed, Sep 12, 2018 at 1:51 AM Vlad Buslov wrote: >> >> >> On Fri 07 Sep 2018 at 19:12, Cong Wang wrote: >> > On Fri, Sep 7, 2018 at 6:52 AM Vlad Buslov wrote: >> >> >> >> Action API was changed to work with actions and action_idr in concurrenc

Re: [PATCH net-next v2] net: sched: change tcf_del_walker() to take idrinfo->lock

2018-09-13 Thread Cong Wang
On Wed, Sep 12, 2018 at 1:51 AM Vlad Buslov wrote: > > > On Fri 07 Sep 2018 at 19:12, Cong Wang wrote: > > On Fri, Sep 7, 2018 at 6:52 AM Vlad Buslov wrote: > >> > >> Action API was changed to work with actions and action_idr in concurrency > >> safe manner, however tcf_del_walker() still uses a

Re: [PATCH net-next v2] net: sched: change tcf_del_walker() to take idrinfo->lock

2018-09-12 Thread Vlad Buslov
On Fri 07 Sep 2018 at 19:12, Cong Wang wrote: > On Fri, Sep 7, 2018 at 6:52 AM Vlad Buslov wrote: >> >> Action API was changed to work with actions and action_idr in concurrency >> safe manner, however tcf_del_walker() still uses actions without taking a >> reference or idrinfo->lock first, and

Re: [PATCH net-next v2] net: sched: change tcf_del_walker() to take idrinfo->lock

2018-09-07 Thread Cong Wang
On Fri, Sep 7, 2018 at 6:52 AM Vlad Buslov wrote: > > Action API was changed to work with actions and action_idr in concurrency > safe manner, however tcf_del_walker() still uses actions without taking a > reference or idrinfo->lock first, and deletes them directly, disregarding > possible concurr

[PATCH net-next v2] net: sched: change tcf_del_walker() to take idrinfo->lock

2018-09-07 Thread Vlad Buslov
Action API was changed to work with actions and action_idr in concurrency safe manner, however tcf_del_walker() still uses actions without taking a reference or idrinfo->lock first, and deletes them directly, disregarding possible concurrent delete. Add tc_action_wq workqueue to action API. Implem